Skip to content

Commit 130c6e6

Browse files
Commit for the changes to upgrade nginx version to 1.24.0 and 1.25.3 (#340)
* commit for the changes to upgrade nginx version to 1.24.0 and 1.25.3 * readme.md updated
1 parent 0930baa commit 130c6e6

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

instrumentation/otel-webserver-module/README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ Currently, Nginx Webserver module monitores some fixed set of modules, which get
150150

151151
| Library | Present Version |
152152
| ---------------------------------------------- | ----------- |
153-
| Nginx | 1.22.0, 1.23.0,1.23.1 |
153+
| Nginx | 1.24.0, 1.25.3 |
154154
| Apr | 1.7.0 |
155155
| Apr-util | 1.6.1 |
156156

@@ -182,7 +182,7 @@ Currently, Nginx Webserver module monitores some fixed set of modules, which get
182182
- Docker Desktop should be installed on the system
183183

184184
#### Platform Supported
185-
- Supports both stable(1.22.0) and mainline(1.23.1).
185+
- Supports both stable(1.24.0) and mainline(1.25.3).
186186
- Earlier support of v1.18.0 is deprecated.
187187
- The build is supported for **x86-64** platforms.
188188
- OS support: **Centos6**, **Centos7, ubuntu20.04**.

instrumentation/otel-webserver-module/docker/centos7/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ ARG AUTOMAKE_VERSION="1.16.3"
2626
ARG PERL_VERSION="5.20.2"
2727
ARG PERL_CPANVERSION="5.0"
2828
ARG PCRE_VERSION="8.44"
29-
ARG NGINX_VERSION="1.22.0"
29+
ARG NGINX_VERSION="1.24.0"
3030

3131
# create default non-root user
3232
RUN groupadd -r swuser && useradd -u 1000 -g swuser -m -s /sbin/nologin -c "default non-root user" swuser
@@ -290,7 +290,7 @@ RUN cd /otel-webserver-module/build \
290290
&& cd /
291291

292292
RUN cp /otel-webserver-module/conf/nginx/opentelemetry_module.conf /opt/ \
293-
&& sed -i '8i load_module /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/1.22.0/ngx_http_opentelemetry_module.so;' /etc/nginx/nginx.conf \
293+
&& sed -i '8i load_module /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/1.24.0/ngx_http_opentelemetry_module.so;' /etc/nginx/nginx.conf \
294294
&& sed -i '33i include /opt/opentelemetry_module.conf;' /etc/nginx/nginx.conf \
295295
&& cd /
296296

instrumentation/otel-webserver-module/docker/ubuntu20.04/Dockerfile

+2-2
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ ARG APRUTIL_VERSION="1.6.1"
3838
ARG LOG4CXX_VERSION="0.11.0"
3939
ARG GTEST_VERSION="1.10.0"
4040
ARG PCRE_VERSION="8.44"
41-
ARG NGINX_VERSION="1.22.0"
41+
ARG NGINX_VERSION="1.24.0"
4242

4343
# Install GRPC
4444
RUN git clone --shallow-submodules --depth 1 --recurse-submodules -b v${GRPC_VERSION} \
@@ -213,7 +213,7 @@ RUN cd /otel-webserver-module/build \
213213

214214
RUN cd /otel-webserver-module/build \
215215
&& cp ../conf/nginx/opentelemetry_module.conf /opt/ \
216-
&& sed -i '5i load_module /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/1.22.0/ngx_http_opentelemetry_module.so;' /etc/nginx/nginx.conf \
216+
&& sed -i '5i load_module /opt/opentelemetry-webserver-sdk/WebServerModule/Nginx/1.24.0/ngx_http_opentelemetry_module.so;' /etc/nginx/nginx.conf \
217217
&& sed -i '33i include /opt/opentelemetry_module.conf;' /etc/nginx/nginx.conf \
218218
&& cd /opt/opentelemetry-webserver-sdk \
219219
&& ./install.sh \

instrumentation/otel-webserver-module/include/core/api/Payload.h

+11-11
Original file line numberDiff line numberDiff line change
@@ -71,18 +71,18 @@ class RequestPayload
7171
void set_port(long aPort) {port = aPort; }
7272

7373

74-
std::string get_uri() { return uri; }
75-
std::string get_request_protocol() { return request_protocol; }
76-
std::string get_http_get_parameter() { return http_get_parameter; }
77-
std::string get_http_post_parameter() { return http_post_parameter; }
78-
std::string get_http_request_method() { return http_request_method; }
74+
std::string& get_uri() { return uri; }
75+
std::string& get_request_protocol() { return request_protocol; }
76+
std::string& get_http_get_parameter() { return http_get_parameter; }
77+
std::string& get_http_post_parameter() { return http_post_parameter; }
78+
std::string& get_http_request_method() { return http_request_method; }
7979
std::unordered_map<std::string, std::string> get_http_headers() { return http_headers; }
80-
std::string get_server_name() { return server_name; }
81-
std::string get_scheme() {return scheme; }
82-
std::string get_host() {return host; }
83-
std::string get_target() {return target; }
84-
std::string get_flavor() {return flavor; }
85-
std::string get_client_ip() {return client_ip; }
80+
std::string& get_server_name() { return server_name; }
81+
std::string& get_scheme() {return scheme; }
82+
std::string& get_host() {return host; }
83+
std::string& get_target() {return target; }
84+
std::string& get_flavor() {return flavor; }
85+
std::string& get_client_ip() {return client_ip; }
8686
long get_port() {return port; }
8787
std::unordered_map<std::string, std::string>& get_request_headers() {
8888
return request_headers;
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
server-module-version=1.0.3
22
release=GA
3-
nginxSupportedVersions=1.22.0,1.23.0,1.23.1
3+
nginxSupportedVersions=1.24.0,1.25.3
44
CPP-SDK-version=1.2.0

0 commit comments

Comments
 (0)