remove redundant isDisposing pattern in StressTest (#6082)

Co-authored-by: Rajkumar Rangaraj <[email protected]>

Author: SimonCropp

test/OpenTelemetry.Tests.Stress.Logs/Program.cs

@@ -32,6 +32,12 @@ public LogsStressTest(StressTestOptions options)
             this.logger = this.loggerFactory.CreateLogger<LogsStressTest>();
         }
 
+        public override void Dispose()
+        {
+            this.loggerFactory.Dispose();
+            base.Dispose();
+        }
+
         protected override void RunWorkItemInParallel()
         {
             this.logger.FoodRecallNotice(
@@ -41,15 +47,5 @@ protected override void RunWorkItemInParallel()
                 recallReasonDescription: "due to a possible health risk from Listeria monocytogenes",
                 companyName: "Contoso Fresh Vegetables, Inc.");
         }
-
-        protected override void Dispose(bool isDisposing)
-        {
-            if (isDisposing)
-            {
-                this.loggerFactory.Dispose();
-            }
-
-            base.Dispose(isDisposing);
-        }
     }
 }

test/OpenTelemetry.Tests.Stress.Metrics/Program.cs

@@ -77,6 +77,12 @@ public MetricsStressTest(MetricsStressTestOptions options)
             this.meterProvider = builder.Build();
         }
 
+        public override void Dispose()
+        {
+            this.meterProvider.Dispose();
+            base.Dispose();
+        }
+
         protected override void WriteRunInformationToConsole()
         {
             if (this.Options.PrometheusTestMetricsPort != 0)
@@ -105,16 +111,6 @@ protected override void RunWorkItemInParallel()
                    new("DimName3", DimensionValues[random.Next(0, ArraySize)]));
             }
         }
-
-        protected override void Dispose(bool isDisposing)
-        {
-            if (isDisposing)
-            {
-                this.meterProvider.Dispose();
-            }
-
-            base.Dispose(isDisposing);
-        }
     }
 
     private sealed class MetricsStressTestOptions : StressTestOptions

test/OpenTelemetry.Tests.Stress.Traces/Program.cs

@@ -26,21 +26,14 @@ public TracesStressTest(StressTestOptions options)
                 .Build();
         }
 
+        public override void Dispose() =>
+            this.tracerProvider.Dispose();
+
         protected override void RunWorkItemInParallel()
         {
             using var activity = ActivitySource.StartActivity("test");
 
             activity?.SetTag("foo", "value");
         }
-
-        protected override void Dispose(bool isDisposing)
-        {
-            if (isDisposing)
-            {
-                this.tracerProvider.Dispose();
-            }
-
-            base.Dispose(isDisposing);
-        }
     }
 }

test/OpenTelemetry.Tests.Stress/StressTest.cs

@@ -22,10 +22,8 @@ protected StressTest(T options)
 
     public T Options { get; }
 
-    public void Dispose()
+    public virtual void Dispose()
     {
-        this.Dispose(true);
-        GC.SuppressFinalize(this);
     }
 
     public void RunSynchronously()
@@ -203,10 +201,6 @@ protected virtual void WriteRunInformationToConsole()
 
     protected abstract void RunWorkItemInParallel();
 
-    protected virtual void Dispose(bool isDisposing)
-    {
-    }
-
     // Padding to avoid false sharing.
     // For most systems, the cache line size should be less than or equal to 128 bytes.
     private struct MeasurementData