pr feedback

Author: TimothyMothra

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/OtlpGrpcExportClient.cs

@@ -93,7 +93,7 @@ public override ExportClientResponse SendExportRequest(byte[] buffer, int conten
                 grpcStatusDetailsHeader = GrpcProtocolHelpers.GetHeaderValue(trailingHeaders, GrpcStatusDetailsHeader);
             }
 
-            OpenTelemetryProtocolExporterEventSource.Log.ExportFailure(this.Endpoint.ToString(), "Export failed due to unexpected status code.", status.StatusCode.ToString());
+            OpenTelemetryProtocolExporterEventSource.Log.ExportFailure(this.Endpoint.ToString(), "Export failed due to unexpected status code.", status);
 
             return new ExportClientGrpcResponse(
                 success: false,

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/OpenTelemetryProtocolExporterEventSource.cs

@@ -3,6 +3,7 @@
 
 using System.Diagnostics.Tracing;
 using Microsoft.Extensions.Configuration;
+using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation.ExportClient.Grpc;
 using OpenTelemetry.Internal;
 
 namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation;
@@ -92,6 +93,15 @@ public void GrpcRetryDelayParsingFailed(string? grpcStatusDetailsHeader, Excepti
         {
             this.GrpcRetryDelayParsingFailed(grpcStatusDetailsHeader ?? "null", ex.ToInvariantString());
         }
+    }
+
+    [NonEvent]
+    public void ExportFailure(string endpoint, string message, Status status)
+    {
+        if (Log.IsEnabled(EventLevel.Error, EventKeywords.All))
+        {
+            this.ExportFailure(endpoint, message, status.StatusCode.ToString(), status.Detail);
+        }
     }
 
     [Event(2, Message = "Exporter failed send data to collector to {0} endpoint. Data will not be sent. Exception: {1}", Level = EventLevel.Error)]
@@ -206,12 +216,12 @@ public void ExportSuccess(string endpoint, string message)
     public void GrpcStatusWarning(string endpoint, string statusCode)
     {
         this.WriteEvent(22, endpoint, statusCode);
-    }
+    }
 
-    [Event(23, Message = "Export failed for {0}. Message: {1}. Status code: {2}", Level = EventLevel.Error)]
-    public void ExportFailure(string endpoint, string message, string statusCode)
+    [Event(23, Message = "Export failed for {0}. Message: {1}. Status Code: {2}. Detail: {3}.", Level = EventLevel.Error)]
+    public void ExportFailure(string endpoint, string message, string statusCode, string detail)
     {
-        this.WriteEvent(23, endpoint, message, statusCode);
+        this.WriteEvent(23, endpoint, message, statusCode, detail);
     }
 
     [Event(24, Message = "Failed to parse gRPC retry delay from header grpcStatusDetailsHeader: '{0}'. Exception: {1}", Level = EventLevel.Warning)]