[otlp] Rename ProgrammaticallyModifiedEndpoint -> AppendSignalPathToEndpoint (#5427)

Author: CodeBlanch

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/Implementation/ExportClient/BaseOtlpHttpExportClient.cs

@@ -21,7 +21,7 @@ protected BaseOtlpHttpExportClient(OtlpExporterOptions options, HttpClient httpC
         Guard.ThrowIfNull(signalPath);
         Guard.ThrowIfInvalidTimeout(options.TimeoutMilliseconds);
 
-        Uri exporterEndpoint = !options.ProgrammaticallyModifiedEndpoint
+        Uri exporterEndpoint = options.AppendSignalPathToEndpoint
             ? options.Endpoint.AppendPathIfNotPresent(signalPath)
             : options.Endpoint;
         this.Endpoint = new UriBuilder(exporterEndpoint).Uri;

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs

@@ -114,7 +114,7 @@ public Uri Endpoint
         set
         {
             this.endpoint = value;
-            this.ProgrammaticallyModifiedEndpoint = true;
+            this.AppendSignalPathToEndpoint = false;
         }
     }
 
@@ -180,9 +180,14 @@ public Uri Endpoint
     public Func<HttpClient> HttpClientFactory { get; set; }
 
     /// <summary>
-    /// Gets a value indicating whether <see cref="Endpoint" /> was modified via its setter.
+    /// Gets a value indicating whether or not the signal-specific path should
+    /// be appended to <see cref="Endpoint"/>.
     /// </summary>
-    internal bool ProgrammaticallyModifiedEndpoint { get; private set; }
+    /// <remarks>
+    /// Note: Only applicable when <see cref="OtlpExportProtocol.HttpProtobuf"/>
+    /// is used.
+    /// </remarks>
+    internal bool AppendSignalPathToEndpoint { get; private set; } = true;
 
     internal static void RegisterOtlpExporterOptionsFactory(IServiceCollection services)
     {