Skip to content

Commit 9261a67

Browse files
authored
[otlp] Add comments capturing details about SYSLIB1100 & SYSLIB1101 suppressions in project (#5523)
1 parent dde68fa commit 9261a67

File tree

1 file changed

+8
-1
lines changed

1 file changed

+8
-1
lines changed

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OpenTelemetry.Exporter.OpenTelemetryProtocol.csproj

+8-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,14 @@
99
<Nullable>disable</Nullable>
1010
<DefineConstants>BUILDING_INTERNAL_PERSISTENT_STORAGE;$(DefineConstants)</DefineConstants>
1111
<EnableConfigurationBindingGenerator>true</EnableConfigurationBindingGenerator>
12-
<!-- SYSLIB1100;SYSLIB1101 - Configuration.Binder: can't create instance and unsupported type -->
12+
13+
<!-- Note: SYSLIB1100;SYSLIB1101 - Configuration.Binder: Can't create
14+
instance and unsupported type are being emitted by config source generator
15+
processing OtlpExporterBuilderOptions. It would be preferable to suppress
16+
this at the call site but there is a bug. This could possibly be cleaned up
17+
in the future (hopefully .NET 9) see:
18+
https://github.com/open-telemetry/opentelemetry-dotnet/pull/5520#discussion_r1556221048
19+
and https://github.com/dotnet/runtime/issues/92509 -->
1320
<NoWarn>$(NoWarn);SYSLIB1100;SYSLIB1101</NoWarn>
1421
</PropertyGroup>
1522

0 commit comments

Comments
 (0)