Skip to content

Commit 928c039

Browse files
author
Timothy Mothra Lee
committed
sync changes in shared files
1 parent 9adb088 commit 928c039

File tree

3 files changed

+15
-7
lines changed

3 files changed

+15
-7
lines changed

src/Shared/ActivityInstrumentationHelper.cs

-1
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
// SPDX-License-Identifier: Apache-2.0
33

44
using System.Diagnostics;
5-
#pragma warning restore IDE0005
65

76
namespace OpenTelemetry.Instrumentation;
87

src/Shared/ResourceSemanticConventions.cs

+9-1
Original file line numberDiff line numberDiff line change
@@ -45,9 +45,17 @@ internal static class ResourceSemanticConventions
4545
public const string AttributeProcessCommandLine = "process.command_line";
4646
public const string AttributeProcessUsername = "process.username";
4747

48-
public const string AttributeCloudProvider = "cloud.provider";
4948
public const string AttributeCloudAccount = "cloud.account.id";
49+
public const string AttributeCloudPlatform = "cloud.platform";
50+
public const string AttributeCloudProvider = "cloud.provider";
5051
public const string AttributeCloudRegion = "cloud.region";
52+
public const string AttributeCloudResourceId = "cloud.resource_id";
5153
public const string AttributeCloudZone = "cloud.zone";
54+
5255
public const string AttributeComponent = "component";
56+
57+
public const string AttributeOsType = "os.type";
58+
public const string AttributeOsVersion = "os.version";
59+
60+
public const string AttributeDeploymentEnvironment = "deployment.environment";
5361
}

src/Shared/SemanticConventions.cs

+6-5
Original file line numberDiff line numberDiff line change
@@ -100,22 +100,23 @@ internal static class SemanticConventions
100100
public const string AttributeErrorType = "error.type";
101101

102102
// v1.21.0
103-
// https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/http/http-spans.md
104103
// https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/database/database-spans.md
105-
// https://github.com/open-telemetry/semantic-conventions/blob/v1.21.0/docs/rpc/rpc-spans.md
104+
public const string AttributeServerSocketAddress = "server.socket.address"; // replaces: "net.peer.ip" (AttributeNetPeerIp)
105+
106+
// v1.23.0
107+
// https://github.com/open-telemetry/semantic-conventions/blob/v1.23.0/docs/http/http-spans.md
106108
public const string AttributeClientAddress = "client.address";
107109
public const string AttributeClientPort = "client.port";
108110
public const string AttributeHttpRequestMethod = "http.request.method"; // replaces: "http.method" (AttributeHttpMethod)
111+
public const string AttributeHttpRequestMethodOriginal = "http.request.method_original";
109112
public const string AttributeHttpResponseStatusCode = "http.response.status_code"; // replaces: "http.status_code" (AttributeHttpStatusCode)
110113
public const string AttributeNetworkProtocolVersion = "network.protocol.version"; // replaces: "http.flavor" (AttributeHttpFlavor)
111114
public const string AttributeNetworkProtocolName = "network.protocol.name";
112115
public const string AttributeServerAddress = "server.address"; // replaces: "net.host.name" (AttributeNetHostName) and "net.peer.name" (AttributeNetPeerName)
113116
public const string AttributeServerPort = "server.port"; // replaces: "net.host.port" (AttributeNetHostPort) and "net.peer.port" (AttributeNetPeerPort)
114-
public const string AttributeServerSocketAddress = "server.socket.address"; // replaces: "net.peer.ip" (AttributeNetPeerIp)
115117
public const string AttributeUrlFull = "url.full"; // replaces: "http.url" (AttributeHttpUrl)
116118
public const string AttributeUrlPath = "url.path"; // replaces: "http.target" (AttributeHttpTarget)
117-
public const string AttributeUrlScheme = "url.scheme"; // replaces: "http.scheme" (AttributeHttpScheme)
118119
public const string AttributeUrlQuery = "url.query";
120+
public const string AttributeUrlScheme = "url.scheme"; // replaces: "http.scheme" (AttributeHttpScheme)
119121
public const string AttributeUserAgentOriginal = "user_agent.original"; // replaces: "http.user_agent" (AttributeHttpUserAgent)
120-
public const string AttributeHttpRequestMethodOriginal = "http.request.method_original";
121122
}

0 commit comments

Comments
 (0)