Skip to content

Commit ad047ab

Browse files
committed
#pragma warning description
1 parent 7f12af9 commit ad047ab

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

src/OpenTelemetry.Exporter.Prometheus.AspNetCore/PrometheusExporterMeterProviderBuilderExtensions.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,9 +64,9 @@ public static MeterProviderBuilder AddPrometheusExporter(
6464

6565
private static BaseExportingMetricReader BuildPrometheusExporterMetricReader(PrometheusAspNetCoreOptions options)
6666
{
67-
#pragma warning disable CA2000
67+
#pragma warning disable CA2000 // Dispose objects before losing scope
6868
var exporter = new PrometheusExporter(options.ExporterOptions);
69-
#pragma warning restore CA2000
69+
#pragma warning restore CA2000 // Dispose objects before losing scope
7070

7171
return new BaseExportingMetricReader(exporter)
7272
{

src/OpenTelemetry.Exporter.Prometheus.HttpListener/PrometheusHttpListenerMeterProviderBuilderExtensions.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -78,9 +78,9 @@ private static BaseExportingMetricReader BuildPrometheusHttpListenerMetricReader
7878

7979
try
8080
{
81-
#pragma warning disable CA2000
81+
#pragma warning disable CA2000 // Dispose objects before losing scope
8282
var listener = new PrometheusHttpListener(exporter, options);
83-
#pragma warning restore CA2000
83+
#pragma warning restore CA2000 // Dispose objects before losing scope
8484
exporter.OnDispose = listener.Dispose;
8585
listener.Start();
8686
}

test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusHttpListenerTests.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -122,9 +122,9 @@ public void PrometheusHttpListenerThrowsOnStart()
122122
// Step 1: Start a listener on a random port.
123123
while (retryAttempts-- != 0)
124124
{
125-
#pragma warning disable CA5394
125+
#pragma warning disable CA5394 // Do not use insecure randomness
126126
int port = random.Next(2000, 5000);
127-
#pragma warning restore CA5394
127+
#pragma warning restore CA5394 // Do not use insecure randomness
128128
address = $"http://localhost:{port}/";
129129

130130
try
@@ -229,9 +229,9 @@ private static MeterProvider BuildMeterProvider(Meter meter, IEnumerable<KeyValu
229229

230230
while (retryAttempts-- != 0)
231231
{
232-
#pragma warning disable CA5394
232+
#pragma warning disable CA5394 // Do not use insecure randomness
233233
int port = random.Next(2000, 5000);
234-
#pragma warning restore CA5394
234+
#pragma warning restore CA5394 // Do not use insecure randomness
235235
generatedAddress = $"http://localhost:{port}/";
236236

237237
try

0 commit comments

Comments
 (0)