Skip to content

Commit dd4e212

Browse files
[Exporter.OpenTelemetryProtocol] fix event source throws System.FormatException (#5451)
1 parent 59f829d commit dd4e212

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

src/OpenTelemetry.Exporter.OpenTelemetryProtocol/PersistentStorage/PersistentStorageEventSource.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ public void CouldNotRemoveExpiredLease(string srcFilePath, string destFilePath,
145145
this.WriteEvent(8, srcFilePath, destFilePath, ex);
146146
}
147147

148-
[Event(9, Message = "{0}: Error Message: {1}. Exception: {3}", Level = EventLevel.Error)]
148+
[Event(9, Message = "{0}: Error Message: {1}. Exception: {2}", Level = EventLevel.Error)]
149149
public void PersistentStorageException(string className, string message, string ex)
150150
{
151151
this.WriteEvent(9, className, message, ex);

test/OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests/EventSourceTest.cs

+14
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// SPDX-License-Identifier: Apache-2.0
33

44
using OpenTelemetry.Exporter.OpenTelemetryProtocol.Implementation;
5+
using OpenTelemetry.PersistentStorage.Abstractions;
6+
using OpenTelemetry.PersistentStorage.FileSystem;
57
using OpenTelemetry.Tests;
68
using Xunit;
79

@@ -14,4 +16,16 @@ public void EventSourceTest_OpenTelemetryProtocolExporterEventSource()
1416
{
1517
EventSourceTestHelper.MethodsAreImplementedConsistentlyWithTheirAttributes(OpenTelemetryProtocolExporterEventSource.Log);
1618
}
19+
20+
[Fact]
21+
public void EventSourceTest_PersistentStorageAbstractionsEventSource()
22+
{
23+
EventSourceTestHelper.MethodsAreImplementedConsistentlyWithTheirAttributes(PersistentStorageAbstractionsEventSource.Log);
24+
}
25+
26+
[Fact]
27+
public void EventSourceTest_PersistentStorageEventSource()
28+
{
29+
EventSourceTestHelper.MethodsAreImplementedConsistentlyWithTheirAttributes(PersistentStorageEventSource.Log);
30+
}
1731
}

0 commit comments

Comments
 (0)