[Shims.OpenTracing] enable code analysis #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
pkg:OpenTelemetry.Shims.OpenTracing
Kielek
force-pushed
the
analysis-OpenTelemetry.Shims.OpenTracing
branch
from
df0310f to
dbab7dd
Compare
| @@ -65,7 +65,7 @@ public SpanBuilderShim(Tracer tracer, string spanName) | |||
| this.ScopeManager = new ScopeManagerShim(); | |||
| } | |||
|
|
|||
| private IScopeManager ScopeManager { get; } | |||
| private ScopeManagerShim ScopeManager { get; } | |||
There was a problem hiding this comment.
FYI
CA1859 Change type of property 'ScopeManager' from 'OpenTracing.IScopeManager' to 'OpenTelemetry.Shims.OpenTracing.ScopeManagerShim' for improved performance
TimothyMothra
approved these changes
Mar 7, 2025
rajkumar-rangaraj
approved these changes
Mar 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6160 +/- ##
==========================================
- Coverage 86.30% 86.29% -0.01%
==========================================
Files 257 257
Lines 11498 11490 -8
==========================================
- Hits 9923 9915 -8
Misses 1575 1575
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #3958
Changes
[Shims.OpenTracing] enable code analysis
Merge requirement checklist
[ ] AppropriateCHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)