Skip to content

[jmx-scraper] test all the possible ways to provide configuration #1687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SylvainJuge opened this issue Feb 4, 2025 · 0 comments · Fixed by #1750
Closed

[jmx-scraper] test all the possible ways to provide configuration #1687

SylvainJuge opened this issue Feb 4, 2025 · 0 comments · Fixed by #1750

Comments

@SylvainJuge
Copy link
Contributor

Currently, the JMX scraper tests are all using JVM system properties for configuration.

However, there are other ways to provide the configuration and they aren't tested end-to-end:

  • standard input
  • environment variables
  • external properties file.

In order to test those, we should at least attempt to cover the minimal configuration for each of the 4 ways to configure it, we don't have to test every configuration option with every possible way to provide it.

In addition, doing that test work based on "test connnection" implemented in #1684 would be relevant as it allows to test the whole CLI program as the user would experience it. Work on this issue would then depend on #1684 to be merged though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants