-
Notifications
You must be signed in to change notification settings - Fork 961
Add config for scraping Trino metrics #13550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would suggest to only add new supported systems directly in instrumentation as we can now reuse them directly with jmx-scraper thanks to open-telemetry/opentelemetry-java-contrib#1782. However, most of the code to test new systems is in #13392 which is not merged yet due to lack of ability to filter negative values. In practice this does not prevent starting the fun part which is to create a yaml file and define metrics by putting it in the right location in classpath (see tests in open-telemetry/opentelemetry-java-contrib#1782). |
Thanks @SylvainJuge you make a good point about adding to instrumentation first. What do you think about us moving this issue then over to the instrumentation repo? |
Yes, moving the issue to instrumentation would make sense here. It's probably a good idea to start working on this only once we have merged the JVM metrics PR as it provides the test infrastructure. |
The "test infrastructure" code I war referring to in my previous comment has been merged with #13597, which means you should be able to reuse it and it should be a matter of adding a new yaml file and implementing the tests for it. |
Uh oh!
There was an error while loading. Please reload this page.
Component(s)
jmx-scraper
Is your feature request related to a problem? Please describe.
Trino publishes a set of JMX metrics: https://trino.io/docs/current/admin/jmx.html
We could incorporate a configuration that would allow users to scrape these with the
jmx-scraper
.Describe the solution you'd like
It would be awesome if the
jmx-scraper
had out-of-the-box support for scraping the Trino metrics. https://trino.io/docs/current/admin/jmx.htmlThe text was updated successfully, but these errors were encountered: