Skip to content

Commit 7f3b53e

Browse files
fix: add java17 as compatible runtime in collector makefile (#1667)
* fix: add java17 as compatible runtime in collector makefile * Add java21 to the supported runtimes list --------- Co-authored-by: Tyler Benson <[email protected]>
1 parent e1d2c21 commit 7f3b53e

File tree

5 files changed

+10
-4
lines changed

5 files changed

+10
-4
lines changed

.github/workflows/ci-python.yml

+2
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,8 @@ jobs:
2626

2727
strategy:
2828
matrix:
29+
# If you add a python version here, please make sure that the collector/Makefile publish and publish-layer targets
30+
# get updated as well
2931
python: ['3.8', '3.9', '3.10', '3.11', '3.12']
3032

3133
steps:

.github/workflows/release-layer-java.yml

+3-1
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,9 @@ jobs:
102102
layer-name: opentelemetry-javaagent
103103
component-version: ${{needs.build-layer.outputs.JAVAAGENT_VERSION}}
104104
# architecture:
105-
runtimes: java8.al2 java11 java17
105+
# If you add a java runtime here, please make sure that the collector/Makefile publish and publish-layer targets
106+
# get updated as well
107+
runtimes: java8.al2 java11 java17 java21
106108
release-group: prod
107109
aws_region: ${{ matrix.aws_region }}
108110
secrets: inherit

.github/workflows/release-layer-nodejs.yml

+2
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,8 @@ jobs:
8787
layer-name: opentelemetry-nodejs
8888
component-version: ${{needs.build-layer.outputs.NODEJS_VERSION}}
8989
# architecture:
90+
# If you add a nodejs runtime here, please make sure that the collector/Makefile publish and publish-layer targets
91+
# get updated as well
9092
runtimes: nodejs18.x nodejs20.x nodejs22.x
9193
release-group: prod
9294
aws_region: ${{ matrix.aws_region }}

collector/Makefile

+2-2
Original file line numberDiff line numberDiff line change
@@ -47,12 +47,12 @@ package: build
4747

4848
.PHONY: publish
4949
publish:
50-
aws lambda publish-layer-version --layer-name $(LAYER_NAME) --zip-file fileb://$(BUILD_SPACE)/opentelemetry-collector-layer-$(GOARCH).zip --compatible-runtimes nodejs16.x nodejs18.x nodejs20.x nodejs22.x java11 python3.8 python3.9 python3.10 python3.11 python3.12 --query 'LayerVersionArn' --output text
50+
aws lambda publish-layer-version --layer-name $(LAYER_NAME) --zip-file fileb://$(BUILD_SPACE)/opentelemetry-collector-layer-$(GOARCH).zip --compatible-runtimes nodejs16.x nodejs18.x nodejs20.x nodejs22.x java11 java17 java21 python3.8 python3.9 python3.10 python3.11 python3.12 --query 'LayerVersionArn' --output text
5151

5252
.PHONY: publish-layer
5353
publish-layer: package
5454
@echo Publishing collector extension layer...
55-
aws lambda publish-layer-version --layer-name $(LAYER_NAME) --zip-file fileb://$(BUILD_SPACE)/opentelemetry-collector-layer-$(GOARCH).zip --compatible-runtimes nodejs16.x nodejs18.x nodejs20.x nodejs22.x java11 python3.8 python3.9 python3.10 python3.11 python3.12 --query 'LayerVersionArn' --output text
55+
aws lambda publish-layer-version --layer-name $(LAYER_NAME) --zip-file fileb://$(BUILD_SPACE)/opentelemetry-collector-layer-$(GOARCH).zip --compatible-runtimes nodejs16.x nodejs18.x nodejs20.x nodejs22.x java11 java17 java21 python3.8 python3.9 python3.10 python3.11 python3.12 --query 'LayerVersionArn' --output text
5656
@echo OpenTelemetry Collector layer published.
5757

5858
.PHONY: set-otelcol-version

java/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ To build the wrapper layer, run
7575
./gradlew :layer-wrapper:build
7676
```
7777

78-
The layer zip file will be present at `./layer-wrapper/build/distributions/opentelemetry-java-wrapper.zip`.
78+
The layer zip file will be present at `./layer-wrapper/build/distributions/opentelemetry-javawrapper-layer.zip`.
7979

8080
## Sample applications
8181

0 commit comments

Comments
 (0)