Skip to content

Commit

Permalink
Fix listing only namespaces containing OpenTelemetry Collector instan…
Browse files Browse the repository at this point in the history
…ces. Fixes #3196 (#3197)

Signed-off-by: Israel Blancas <[email protected]>
  • Loading branch information
iblancasa authored Aug 7, 2024
1 parent eab0b6a commit 92652a5
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 2 deletions.
16 changes: 16 additions & 0 deletions .chloggen/3196-openshift-dashboard-list-wrong-namespaces.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: bug_fix

# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action)
component: operator

# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: "The OpenShift dashboard shown namespaces where PodMonitors or ServiceMonitors were created even if they were not associated to OpenTelemetry Collectors."

# One or more tracking issues related to the change
issues: [3196]

# (Optional) One or more lines of additional information to render under the primary note.
# These lines will be padded with 2 spaces and then inserted directly into the document.
# Use pipe (|) for multiline entries.
subtext: "Now, the dashboard lists only those namespaces where there are OpenTelemetry Collectors."
4 changes: 2 additions & 2 deletions internal/openshift/dashboards/metrics-dashboard.json
Original file line number Diff line number Diff line change
Expand Up @@ -989,14 +989,14 @@
"value": "kube-system"
},
"datasource": "$datasource",
"definition": "label_values(container_network_receive_packets_total, namespace)",
"definition": "label_values(otelcol_process_runtime_heap_alloc_bytes, namespace)",
"hide": 0,
"includeAll": true,
"label": null,
"multi": false,
"name": "namespace",
"options": [],
"query": "label_values(container_network_receive_packets_total, namespace)",
"query": "label_values(otelcol_process_runtime_heap_alloc_bytes, namespace)",
"refresh": 2,
"regex": "",
"skipUrlSync": false,
Expand Down

0 comments on commit 92652a5

Please sign in to comment.