Skip to content

Commit decf712

Browse files
refactor: update error handling to use OpenTelemetry.handle_error API (#1514)
Co-authored-by: Kayla Reopelle <[email protected]>
1 parent 7acac04 commit decf712

File tree

2 files changed

+5
-5
lines changed
  • resources/aws/lib/opentelemetry/resource/detector/aws

2 files changed

+5
-5
lines changed

resources/aws/lib/opentelemetry/resource/detector/aws/ec2.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def detect
5959
resource_attributes[RESOURCE::HOST_TYPE] = identity['instanceType']
6060
resource_attributes[RESOURCE::HOST_NAME] = hostname
6161
rescue StandardError => e
62-
OpenTelemetry.logger.debug("EC2 resource detection failed: #{e.message}")
62+
OpenTelemetry.handle_error(exception: e, message: 'EC2 resource detection failed')
6363
return OpenTelemetry::SDK::Resources::Resource.create({})
6464
end
6565

@@ -133,7 +133,7 @@ def make_request(uri, request)
133133
http.request(request)
134134
end
135135
rescue StandardError => e
136-
OpenTelemetry.logger.debug("EC2 metadata service request failed: #{e.message}")
136+
OpenTelemetry.handle_error(exception: e, message: 'EC2 metadata service request failed')
137137
nil
138138
end
139139
end

resources/aws/lib/opentelemetry/resource/detector/aws/ecs.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ def detect
6868
logs_attributes = get_logs_resource(container_metadata)
6969
resource_attributes.merge!(logs_attributes)
7070
rescue StandardError => e
71-
OpenTelemetry.logger.debug("ECS resource detection failed: #{e.message}")
71+
OpenTelemetry.handle_error(exception: e, message: 'ECS resource detection failed')
7272
return OpenTelemetry::SDK::Resources::Resource.create({})
7373
end
7474

@@ -92,7 +92,7 @@ def fetch_container_id
9292
end
9393
end
9494
rescue Errno::ENOENT => e
95-
OpenTelemetry.logger.debug("Failed to get container ID on ECS: #{e.message}")
95+
OpenTelemetry.handle_error(exception: e, message: 'Failed to get container ID on ECS')
9696
end
9797

9898
''
@@ -139,7 +139,7 @@ def get_logs_resource(container_metadata)
139139
log_attributes[RESOURCE::AWS_LOG_STREAM_NAMES] = [logs_stream_name].compact
140140
log_attributes[RESOURCE::AWS_LOG_STREAM_ARNS] = [logs_stream_arn].compact
141141
else
142-
OpenTelemetry.logger.debug("The metadata endpoint v4 has returned 'awslogs' as 'LogDriver', but there is no 'LogOptions' data")
142+
OpenTelemetry.handle_error(message: 'The metadata endpoint v4 has returned \'awslogs\' as \'LogDriver\', but there is no \'LogOptions\' data')
143143
end
144144
end
145145

0 commit comments

Comments
 (0)