Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor instrumentation/redis tests #1382

Open
zvkemp opened this issue Jan 30, 2025 · 0 comments
Open

test: refactor instrumentation/redis tests #1382

zvkemp opened this issue Jan 30, 2025 · 0 comments

Comments

@zvkemp
Copy link
Contributor

zvkemp commented Jan 30, 2025

As discovered in #1370, the arrangement of redis tests is prone to mistakes — they are grouped perhaps correctly as unit tests, however, the implementation of the target libraries makes this complicated:

  • redis (~> 4): uses the RedisV4Client patches
  • redis-client: uses the RedisClient middleware instrumentation
  • redis (~> 5): a wrapper around RedisClient; uses the RedisClient middleware(s).

In most cases, the actions and expectations should be the same (but there are some edge cases). It may be worthwhile to group the tests based on their target gem rather than the instrumentation used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant