Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release PR #1791 failed with errors #1792

Closed
github-actions bot opened this issue Jan 9, 2025 · 5 comments
Closed

Release PR #1791 failed with errors #1792

github-actions bot opened this issue Jan 9, 2025 · 5 comments
Assignees
Labels

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

A release job failed.

Release PR: #1791
Commit: baeda39


Release job completed with errors.

Failed to release opentelemetry-exporter-otlp 0.29.1:
Command failed with exit code 1: ["gh", "api", "repos/open-telemetry/opentelemetry-ruby/releases", "--input", "-", "-H", "Accept: application/vnd.github.v3+json"]

Successfully released opentelemetry-exporter-otlp-metrics 0.3.0

Successfully released opentelemetry-metrics-api 0.2.0

Successfully released opentelemetry-metrics-sdk 0.5.0

@kaylareopelle
Copy link
Contributor

This is the same error we received in a recent release, #1765, but as far as I can tell, everything was released successfully despite this command failing.

We didn't want to release the opentelemetry-exporter-otlp as part of this release, so I'm not sure why a release of that gem was attempted.

@ericmustin
Copy link
Contributor

i'll take a look!

Image

@ericmustin ericmustin self-assigned this Jan 21, 2025
@ericmustin
Copy link
Contributor

Had a small amount of time to look into this, where I left it is it looks like the toys gem is being optimistic when determining which gems to release https://github.com/dazuma/toys/blob/17ed449da8299f272b834470ff6b279a59e8070b/.toys/release/.lib/release_utils.rb#L436

At a glance This would explain the erroneous attempt to release opentelemetry-exporter-otlp (and subsequent 422 response from GitHub api) even though it only has files changed related to opentelemetry-exporter-otlp-metrics. iiuc, GitHub api returns a 422 if you try to release a tag that's already been released.

Copy link
Contributor Author

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@github-actions github-actions bot added the stale label Feb 22, 2025
@kaylareopelle
Copy link
Contributor

Since we've merged #1799, I'm going to close this issue. If we get another failure like this one, a new issue will open. Thanks, @ericmustin!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants