Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeout and delay values from ENV variable should be in milliseconds #2591

Open
cijothomas opened this issue Feb 3, 2025 · 4 comments · May be fixed by #2656
Open

Timeout and delay values from ENV variable should be in milliseconds #2591

cijothomas opened this issue Feb 3, 2025 · 4 comments · May be fixed by #2656
Assignees
Labels
A-common Area:common issues that not related to specific pillar bug Something isn't working
Milestone

Comments

@cijothomas
Copy link
Member

Following seem to treat as seconds which should be treated as a bug.
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-otlp/src/exporter/mod.rs#L90
https://github.com/open-telemetry/opentelemetry-rust/blob/main/opentelemetry-otlp/src/exporter/tonic/mod.rs#L203

Other places are interpreting it correctly as milliseconds.

@cijothomas cijothomas added bug Something isn't working A-common Area:common issues that not related to specific pillar labels Feb 8, 2025
@cijothomas cijothomas added this to the 0.29 milestone Feb 8, 2025
@mohammadVatandoost
Copy link
Contributor

mohammadVatandoost commented Feb 11, 2025

Here also should be interpreted as milliseconds, right?

Ok(seconds) => Duration::from_secs(seconds),

@cijothomas
Copy link
Member Author

Here also should be interpreted as milliseconds, right?

opentelemetry-rust/opentelemetry-otlp/src/exporter/http/mod.rs

Line 123 in b358202

Ok(seconds) => Duration::from_secs(seconds),

yes!

@mohammadVatandoost
Copy link
Contributor

I would be happy to work on this

@cijothomas
Copy link
Member Author

Thanks @mohammadVatandoost ! Assigned to you!

@mohammadVatandoost mohammadVatandoost linked a pull request Feb 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-common Area:common issues that not related to specific pillar bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants