fix: Indent of generated code for non-required lists. Thanks @sfowl! (#1050)

The `_transform` macro is called at three different places in this file,
but one location was not similarly indented as the other two. This
caused errors in the ruff post_hook like:

```
error: Failed to parse foo/models/foo_request.py:125:9: Expected an indented block after `if` statement
```

The generated code without the indent fix looks like:

```
        if not isinstance(self.foo, Unset):
        _temp_foo = []  # <-- incorrect indent
            for foo_item_data in self.foo:
                foo_item: Union[None, int]
                foo_item = foo_item_data
                _temp_foo.append(foo_item)
            foo = (None, json.dumps(_temp_foo).encode(), 'application/json')
```

---------

Co-authored-by: Dylan Anthony <[email protected]>

Author: sfowl

end_to_end_tests/baseline_openapi_3.0.json

@@ -1910,6 +1910,14 @@
             "title": "Some Required Number",
             "type": "number"
           },
+          "some_int_array": {
+            "title": "Some Integer Array",
+            "type": "array",
+            "items": {
+              "type": "integer",
+              "nullable": true
+            }
+          },
           "some_array": {
             "title": "Some Array",
             "nullable": true,

end_to_end_tests/baseline_openapi_3.1.yaml

@@ -1919,6 +1919,13 @@ info:
           "title": "Some Number",
           "type": "number"
         },
+        "some_int_array": {
+          "title": "Some Integer Array",
+          "type": "array",
+          "items": {
+            "type": ["integer", "null"]
+          }
+        },
         "some_array": {
           "title": "Some Array",
           "type": [ "array", "null" ],

end_to_end_tests/golden-record/my_test_api_client/models/body_upload_file_tests_upload_post.py

@@ -41,6 +41,7 @@ class BodyUploadFileTestsUploadPost:
         a_date (Union[Unset, datetime.date]):
         some_number (Union[Unset, float]):
         some_nullable_number (Union[None, Unset, float]):
+        some_int_array (Union[Unset, List[Union[None, int]]]):
         some_array (Union[List['AFormData'], None, Unset]):
         some_optional_object (Union[Unset, BodyUploadFileTestsUploadPostSomeOptionalObject]):
         some_enum (Union[Unset, DifferentEnum]): An enumeration.
@@ -56,6 +57,7 @@ class BodyUploadFileTestsUploadPost:
     a_date: Union[Unset, datetime.date] = UNSET
     some_number: Union[Unset, float] = UNSET
     some_nullable_number: Union[None, Unset, float] = UNSET
+    some_int_array: Union[Unset, List[Union[None, int]]] = UNSET
     some_array: Union[List["AFormData"], None, Unset] = UNSET
     some_optional_object: Union[Unset, "BodyUploadFileTestsUploadPostSomeOptionalObject"] = UNSET
     some_enum: Union[Unset, DifferentEnum] = UNSET
@@ -102,6 +104,14 @@ def to_dict(self) -> Dict[str, Any]:
         else:
             some_nullable_number = self.some_nullable_number
 
+        some_int_array: Union[Unset, List[Union[None, int]]] = UNSET
+        if not isinstance(self.some_int_array, Unset):
+            some_int_array = []
+            for some_int_array_item_data in self.some_int_array:
+                some_int_array_item: Union[None, int]
+                some_int_array_item = some_int_array_item_data
+                some_int_array.append(some_int_array_item)
+
         some_array: Union[List[Dict[str, Any]], None, Unset]
         if isinstance(self.some_array, Unset):
             some_array = UNSET
@@ -145,6 +155,8 @@ def to_dict(self) -> Dict[str, Any]:
             field_dict["some_number"] = some_number
         if some_nullable_number is not UNSET:
             field_dict["some_nullable_number"] = some_nullable_number
+        if some_int_array is not UNSET:
+            field_dict["some_int_array"] = some_int_array
         if some_array is not UNSET:
             field_dict["some_array"] = some_array
         if some_optional_object is not UNSET:
@@ -201,6 +213,15 @@ def to_multipart(self) -> Dict[str, Any]:
         else:
             some_nullable_number = (None, str(self.some_nullable_number).encode(), "text/plain")
 
+        some_int_array: Union[Unset, Tuple[None, bytes, str]] = UNSET
+        if not isinstance(self.some_int_array, Unset):
+            _temp_some_int_array = []
+            for some_int_array_item_data in self.some_int_array:
+                some_int_array_item: Union[None, int]
+                some_int_array_item = some_int_array_item_data
+                _temp_some_int_array.append(some_int_array_item)
+            some_int_array = (None, json.dumps(_temp_some_int_array).encode(), "application/json")
+
         some_array: Union[Tuple[None, bytes, str], Unset]
 
         if isinstance(self.some_array, Unset):
@@ -245,6 +266,8 @@ def to_multipart(self) -> Dict[str, Any]:
             field_dict["some_number"] = some_number
         if some_nullable_number is not UNSET:
             field_dict["some_nullable_number"] = some_nullable_number
+        if some_int_array is not UNSET:
+            field_dict["some_int_array"] = some_int_array
         if some_array is not UNSET:
             field_dict["some_array"] = some_array
         if some_optional_object is not UNSET:
@@ -324,6 +347,19 @@ def _parse_some_nullable_number(data: object) -> Union[None, Unset, float]:
 
         some_nullable_number = _parse_some_nullable_number(d.pop("some_nullable_number", UNSET))
 
+        some_int_array = []
+        _some_int_array = d.pop("some_int_array", UNSET)
+        for some_int_array_item_data in _some_int_array or []:
+
+            def _parse_some_int_array_item(data: object) -> Union[None, int]:
+                if data is None:
+                    return data
+                return cast(Union[None, int], data)
+
+            some_int_array_item = _parse_some_int_array_item(some_int_array_item_data)
+
+            some_int_array.append(some_int_array_item)
+
         def _parse_some_array(data: object) -> Union[List["AFormData"], None, Unset]:
             if data is None:
                 return data
@@ -371,6 +407,7 @@ def _parse_some_array(data: object) -> Union[List["AFormData"], None, Unset]:
             a_date=a_date,
             some_number=some_number,
             some_nullable_number=some_nullable_number,
+            some_int_array=some_int_array,
             some_array=some_array,
             some_optional_object=some_optional_object,
             some_enum=some_enum,

openapi_python_client/templates/property_templates/list_property.py.jinja

@@ -60,7 +60,7 @@ if not isinstance({{ source }}, Unset):
 {% else %}
 {{ destination }}: {{ type_string }} = UNSET
 if not isinstance({{ source }}, Unset):
-{{ _transform(property, source, destination, True, "to_dict") | indent(4)}}
+    {{ _transform(property, source, destination, True, "to_dict") | indent(4)}}
 {% endif %}
 {% endmacro %}