test: Add more unit test coverage

Author: dbanty

tests/test_parser/test_properties/test_init.py

@@ -611,6 +611,25 @@ def test_property_from_data_ref_not_found(self, mocker):
         assert prop == PropertyError(data=data, detail="Could not find reference in parsed models or enums")
         assert schemas == new_schemas
 
+    def test_property_from_data_invalid_ref(self, mocker):
+        from openapi_python_client.parser.properties import PropertyError, Schemas, property_from_data
+
+        name = mocker.MagicMock()
+        required = mocker.MagicMock()
+        data = oai.Reference.construct(ref=mocker.MagicMock())
+        parse_reference_path = mocker.patch(
+            f"{MODULE_NAME}.parse_reference_path", return_value=PropertyError(detail="bad stuff")
+        )
+        schemas = Schemas()
+
+        prop, new_schemas = property_from_data(
+            name=name, required=required, data=data, schemas=schemas, parent_name="parent", config=mocker.MagicMock()
+        )
+
+        parse_reference_path.assert_called_once_with(data.ref)
+        assert prop == PropertyError(data=data, detail="bad stuff")
+        assert schemas == new_schemas
+
     def test_property_from_data_string(self, mocker):
         from openapi_python_client.parser.properties import Schemas, property_from_data
 

tests/test_parser/test_properties/test_model_property.py

@@ -231,6 +231,32 @@ def test_conflicting_properties_different_types(self, model_property_factory):
 
         assert isinstance(result, PropertyError)
 
+    def test_invalid_reference(self, model_property_factory):
+        from openapi_python_client.parser.properties import Schemas
+        from openapi_python_client.parser.properties.model_property import _process_properties
+
+        data = oai.Schema.construct(allOf=[oai.Reference.construct(ref="ThisIsNotGood")])
+        schemas = Schemas()
+
+        result = _process_properties(data=data, schemas=schemas, class_name="", config=Config())
+
+        assert isinstance(result, PropertyError)
+
+    def test_non_model_reference(self, enum_property_factory):
+        from openapi_python_client.parser.properties import Schemas
+        from openapi_python_client.parser.properties.model_property import _process_properties
+
+        data = oai.Schema.construct(allOf=[oai.Reference.construct(ref="#/First")])
+        schemas = Schemas(
+            classes_by_reference={
+                "/First": enum_property_factory(),
+            }
+        )
+
+        result = _process_properties(data=data, schemas=schemas, class_name="", config=Config())
+
+        assert isinstance(result, PropertyError)
+
     def test_conflicting_properties_same_types(self, model_property_factory):
         from openapi_python_client.parser.properties import Schemas
         from openapi_python_client.parser.properties.model_property import _process_properties