Skip to content

Commit 2408ff8

Browse files
philmdMichael Tokarev
authored andcommitted
hw/ssi/pnv_spi: Return early in transfer()
Return early to simplify next commit. No logical change intended. Cc: [email protected] Signed-off-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Nicholas Piggin <[email protected]> (cherry picked from commit 3feabc1) Signed-off-by: Michael Tokarev <[email protected]>
1 parent 5d30531 commit 2408ff8

File tree

1 file changed

+4
-3
lines changed

1 file changed

+4
-3
lines changed

hw/ssi/pnv_spi.c

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,9 @@ static void transfer(PnvSpi *s, PnvXferBuffer *payload)
217217
PnvXferBuffer *rsp_payload = NULL;
218218

219219
rsp_payload = pnv_spi_xfer_buffer_new();
220+
if (!rsp_payload) {
221+
return;
222+
}
220223
for (int offset = 0; offset < payload->len; offset += s->transfer_len) {
221224
tx = 0;
222225
for (int i = 0; i < s->transfer_len; i++) {
@@ -235,9 +238,7 @@ static void transfer(PnvSpi *s, PnvXferBuffer *payload)
235238
(rx >> (8 * (s->transfer_len - 1) - i * 8)) & 0xFF;
236239
}
237240
}
238-
if (rsp_payload != NULL) {
239-
spi_response(s, s->N1_bits, rsp_payload);
240-
}
241+
spi_response(s, s->N1_bits, rsp_payload);
241242
}
242243

243244
static inline uint8_t get_seq_index(PnvSpi *s)

0 commit comments

Comments
 (0)