Skip to content

Commit 83a1d21

Browse files
committed
server: remove non-working admin jwt update service, #TASK-7922
1 parent 2d7be1b commit 83a1d21

File tree

17 files changed

+2
-264
lines changed

17 files changed

+2
-264
lines changed

opencga-app/src/main/java/org/opencb/opencga/app/cli/admin/AdminCliOptionsParser.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,6 @@ public class AdminCliOptionsParser extends CliOptionsParser {
4646
private final ToolsCommandOptions toolsCommandOptions;
4747
private final ServerCommandOptions serverCommandOptions;
4848
private final PanelCommandOptions panelCommandOptions;
49-
private final AdminCliOptionsParser.MetaCommandOptions metaCommandOptions;
5049
private final MigrationCommandOptions migrationCommandOptions;
5150
private final StorageCommandOptions storageCommandOptions;
5251

@@ -110,11 +109,6 @@ public AdminCliOptionsParser() {
110109
panelSubCommands.addCommand("panelapp", panelCommandOptions.panelAppCommandOptions);
111110
panelSubCommands.addCommand("cancer-gene-census", panelCommandOptions.cancerGeneCensusCommandOptions);
112111

113-
this.metaCommandOptions = new AdminCliOptionsParser.MetaCommandOptions();
114-
this.jCommander.addCommand("meta", this.metaCommandOptions);
115-
JCommander metaSubCommands = this.jCommander.getCommands().get("meta");
116-
metaSubCommands.addCommand("update", this.metaCommandOptions.metaKeyCommandOptions);
117-
118112
this.migrationCommandOptions = new MigrationCommandOptions(jCommander, commonCommandOptions);
119113
this.jCommander.addCommand("migration", this.migrationCommandOptions);
120114
JCommander migrationSubCommands = this.jCommander.getCommands().get("migration");
@@ -323,17 +317,6 @@ public ServerCommandOptions() {
323317
}
324318
}
325319

326-
@Parameters( commandNames = {"meta"}, commandDescription = "Manage Meta data")
327-
public class MetaCommandOptions extends AdminCliOptionsParser.CommandOptions {
328-
329-
public MetaKeyCommandOptions metaKeyCommandOptions;
330-
public AdminCommonCommandOptions commonOptions = AdminCliOptionsParser.this.commonCommandOptions;
331-
332-
public MetaCommandOptions() {
333-
this.metaKeyCommandOptions = new MetaKeyCommandOptions();
334-
}
335-
}
336-
337320
/**
338321
* Auxiliary class for Database connection.
339322
*/
@@ -862,10 +845,6 @@ public ServerCommandOptions getServerCommandOptions() {
862845
return serverCommandOptions;
863846
}
864847

865-
public AdminCliOptionsParser.MetaCommandOptions getMetaCommandOptions() {
866-
return this.metaCommandOptions;
867-
}
868-
869848
public PanelCommandOptions getPanelCommandOptions() {
870849
return panelCommandOptions;
871850
}

opencga-app/src/main/java/org/opencb/opencga/app/cli/admin/AdminMain.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ public static void main(String[] args) {
105105
case "server":
106106
commandExecutor = new ServerCommandExecutor(cliOptionsParser.getServerCommandOptions());
107107
break;
108-
case "meta":
109-
commandExecutor = new MetaCommandExecutor(cliOptionsParser.getMetaCommandOptions());
110-
break;
111108
case "panel":
112109
commandExecutor = new PanelCommandExecutor(cliOptionsParser.getPanelCommandOptions());
113110
break;

opencga-app/src/main/java/org/opencb/opencga/app/cli/admin/executors/MetaCommandExecutor.java

Lines changed: 0 additions & 71 deletions
This file was deleted.

opencga-app/src/main/java/org/opencb/opencga/app/cli/main/OpenCgaCompleter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public abstract class OpenCgaCompleter implements Completer {
5454
.map(Candidate::new)
5555
.collect(toList());
5656

57-
private List<Candidate> adminList = asList( "audit-group-by","catalog-install","catalog-jwt","organizations-list","resource-fetch","users-create","users-import","users-permissions","users-search","users-sync","update-groups-users")
57+
private List<Candidate> adminList = asList( "audit-group-by","catalog-install","organizations-list","resource-fetch","users-create","users-import","users-permissions","users-search","users-sync","update-groups-users")
5858
.stream()
5959
.map(Candidate::new)
6060
.collect(toList());

opencga-app/src/main/java/org/opencb/opencga/app/cli/main/OpencgaCliOptionsParser.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -179,7 +179,6 @@ public OpencgaCliOptionsParser() {
179179
JCommander adminSubCommands = jCommander.getCommands().get("admin");
180180
adminSubCommands.addCommand("audit-group-by", adminCommandOptions.groupByAuditCommandOptions);
181181
adminSubCommands.addCommand("catalog-install", adminCommandOptions.installCatalogCommandOptions);
182-
adminSubCommands.addCommand("catalog-jwt", adminCommandOptions.jwtCatalogCommandOptions);
183182
adminSubCommands.addCommand("organizations-list", adminCommandOptions.listOrganizationsCommandOptions);
184183
adminSubCommands.addCommand("resource-fetch", adminCommandOptions.fetchResourceCommandOptions);
185184
adminSubCommands.addCommand("users-create", adminCommandOptions.createUsersCommandOptions);

opencga-app/src/main/java/org/opencb/opencga/app/cli/main/executors/AdminCommandExecutor.java

Lines changed: 0 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import org.opencb.opencga.core.models.Acl;
1818
import org.opencb.opencga.core.models.admin.DeprecatedGroupSyncParams;
1919
import org.opencb.opencga.core.models.admin.InstallationParams;
20-
import org.opencb.opencga.core.models.admin.JWTParams;
2120
import org.opencb.opencga.core.models.admin.UserImportParams;
2221
import org.opencb.opencga.core.models.admin.UserUpdateGroup;
2322
import org.opencb.opencga.core.models.common.Enums.Resource;
@@ -70,9 +69,6 @@ public void execute() throws Exception {
7069
case "catalog-install":
7170
queryResponse = installCatalog();
7271
break;
73-
case "catalog-jwt":
74-
queryResponse = jwtCatalog();
75-
break;
7672
case "organizations-list":
7773
queryResponse = listOrganizations();
7874
break;
@@ -149,35 +145,6 @@ private RestResponse<ObjectMap> installCatalog() throws Exception {
149145
return openCGAClient.getAdminClient().installCatalog(installationParams);
150146
}
151147

152-
private RestResponse<ObjectMap> jwtCatalog() throws Exception {
153-
logger.debug("Executing jwtCatalog in Admin command line");
154-
155-
AdminCommandOptions.JwtCatalogCommandOptions commandOptions = adminCommandOptions.jwtCatalogCommandOptions;
156-
157-
ObjectMap queryParams = new ObjectMap();
158-
queryParams.putIfNotEmpty("organization", commandOptions.organization);
159-
160-
161-
JWTParams jWTParams = null;
162-
if (commandOptions.jsonDataModel) {
163-
RestResponse<ObjectMap> res = new RestResponse<>();
164-
res.setType(QueryType.VOID);
165-
PrintUtils.println(getObjectAsJSON(categoryName,"/{apiVersion}/admin/catalog/jwt"));
166-
return res;
167-
} else if (commandOptions.jsonFile != null) {
168-
jWTParams = JacksonUtils.getDefaultObjectMapper()
169-
.readValue(new java.io.File(commandOptions.jsonFile), JWTParams.class);
170-
} else {
171-
ObjectMap beanParams = new ObjectMap();
172-
putNestedIfNotEmpty(beanParams, "secretKey", commandOptions.secretKey, true);
173-
174-
jWTParams = JacksonUtils.getDefaultObjectMapper().copy()
175-
.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, true)
176-
.readValue(beanParams.toJson(), JWTParams.class);
177-
}
178-
return openCGAClient.getAdminClient().jwtCatalog(jWTParams, queryParams);
179-
}
180-
181148
private RestResponse<String> listOrganizations() throws Exception {
182149
logger.debug("Executing listOrganizations in Admin command line");
183150

opencga-app/src/main/java/org/opencb/opencga/app/cli/main/options/AdminCommandOptions.java

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ public class AdminCommandOptions {
3535

3636
public GroupByAuditCommandOptions groupByAuditCommandOptions;
3737
public InstallCatalogCommandOptions installCatalogCommandOptions;
38-
public JwtCatalogCommandOptions jwtCatalogCommandOptions;
3938
public ListOrganizationsCommandOptions listOrganizationsCommandOptions;
4039
public FetchResourceCommandOptions fetchResourceCommandOptions;
4140
public CreateUsersCommandOptions createUsersCommandOptions;
@@ -52,7 +51,6 @@ public AdminCommandOptions(CommonCommandOptions commonCommandOptions, JCommander
5251
this.commonCommandOptions = commonCommandOptions;
5352
this.groupByAuditCommandOptions = new GroupByAuditCommandOptions();
5453
this.installCatalogCommandOptions = new InstallCatalogCommandOptions();
55-
this.jwtCatalogCommandOptions = new JwtCatalogCommandOptions();
5654
this.listOrganizationsCommandOptions = new ListOrganizationsCommandOptions();
5755
this.fetchResourceCommandOptions = new FetchResourceCommandOptions();
5856
this.createUsersCommandOptions = new CreateUsersCommandOptions();
@@ -119,26 +117,6 @@ public class InstallCatalogCommandOptions {
119117

120118
}
121119

122-
@Parameters(commandNames = {"catalog-jwt"}, commandDescription ="Change JWT secret key")
123-
public class JwtCatalogCommandOptions {
124-
125-
@ParametersDelegate
126-
public CommonCommandOptions commonOptions = commonCommandOptions;
127-
128-
@Parameter(names = {"--json-file"}, description = "File with the body data in JSON format. Note, that using this parameter will ignore all the other parameters.", required = false, arity = 1)
129-
public String jsonFile;
130-
131-
@Parameter(names = {"--json-data-model"}, description = "Show example of file structure for body data.", help = true, arity = 0)
132-
public Boolean jsonDataModel = false;
133-
134-
@Parameter(names = {"--organization"}, description = "Organization id", required = false, arity = 1)
135-
public String organization;
136-
137-
@Parameter(names = {"--secret-key"}, description = "The body web service secretKey parameter", required = false, arity = 1)
138-
public String secretKey;
139-
140-
}
141-
142120
@Parameters(commandNames = {"organizations-list"}, commandDescription ="List current Organizations")
143121
public class ListOrganizationsCommandOptions {
144122

opencga-catalog/src/main/java/org/opencb/opencga/catalog/db/DBAdaptorFactory.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,8 +79,6 @@ default String getCatalogDatabase(String prefix, String organization) {
7979

8080
MigrationDBAdaptor getMigrationDBAdaptor(String organization) throws CatalogDBException;
8181

82-
MetaDBAdaptor getCatalogMetaDBAdaptor(String organization) throws CatalogDBException;
83-
8482
OpenCGAResult<Organization> createOrganization(Organization organization, QueryOptions options, String userId) throws CatalogException;
8583

8684
void deleteOrganization(Organization organization) throws CatalogDBException;

opencga-catalog/src/main/java/org/opencb/opencga/catalog/db/mongodb/MongoDBAdaptorFactory.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -258,11 +258,6 @@ public MigrationDBAdaptor getMigrationDBAdaptor(String organizationId) throws Ca
258258
return getOrganizationMongoDBAdaptorFactory(organizationId).getMigrationDBAdaptor();
259259
}
260260

261-
@Override
262-
public MetaDBAdaptor getCatalogMetaDBAdaptor(String organizationId) throws CatalogDBException {
263-
return getOrganizationMongoDBAdaptorFactory(organizationId).getCatalogMetaDBAdaptor();
264-
}
265-
266261
@Override
267262
public OpenCGAResult<Organization> createOrganization(Organization organization, QueryOptions options, String userId)
268263
throws CatalogException {

opencga-catalog/src/main/java/org/opencb/opencga/catalog/db/mongodb/OrganizationMongoDBAdaptorFactory.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -435,10 +435,6 @@ public MigrationMongoDBAdaptor getMigrationDBAdaptor() {
435435
return migrationDBAdaptor;
436436
}
437437

438-
public MetaMongoDBAdaptor getCatalogMetaDBAdaptor() {
439-
return null;
440-
}
441-
442438
public NoteMongoDBAdaptor getCatalogNotesDBAdaptor() {
443439
return notesDBAdaptor;
444440
}

0 commit comments

Comments
 (0)