-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenAPI has incorrect entries #8
Comments
neomantra
added a commit
to neomantra/go-openchargemap
that referenced
this issue
Feb 27, 2024
See this upstream issue: openchargemap/ocm-docs#8
Found another one:
|
neomantra
added a commit
to neomantra/go-openchargemap
that referenced
this issue
Feb 29, 2024
See this upstream issue: openchargemap/ocm-docs#8
Thanks! It would be great if you could submit a PR with the changes you think should be made. I normally manually edit the OpenAPI YAML using Stoplight studio, then when we push the update to github it automatically updates the docs page. |
I will be happy to — I wasn’t sure if this file was actually the correct one to modify, so thanks for the clarification. |
Thanks, yes that's the one. |
neomantra
added a commit
to neomantra/ocm-docs
that referenced
this issue
Mar 1, 2024
* `latitude` in POI is `number`, not `integer` * `UserComments` IDs are `integer`, not `string` * `MediaItem` IDs are `integer`, not `string`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In the course of making and using
go-openchargemap
, some POI queries were failing due to inconsistencies between the OpenChargeMap OpenAPI spec and the the OpenChargeMap implementation:UserComment:
ID
isint
in the code but is astring
in the OpenAPI YAML.MediaItems:
ID
andChargePointID
areint
in the code, but they arestring
in the OpenAPI YAML.You can find my modified OCM OpenAPI YAML here... In addition to the fixes here, it also adds:
x-go-name: ChargePoint
line due to Golang generation issuesboundingbox
query param fromarray
tostring
as I was having issues; I think that might be me though.I have tremendous gratitude for this project! Thank you! ❤️
The text was updated successfully, but these errors were encountered: