Fix tests

[peterdudfield]

The CI tests are currently failing, it would be great to get these working again

[jramosss]

Hey there, i see that the last failing pipeline shows that ruff is failing, and i see there are tons of errors
see here
Is the pipeline expected to fail when not meeting this requirements, should the "real issue" be fix formatting or maybe loose the rules a little bit?

[peterdudfield]

yea, perhaps it is to fix the formatting. What do you think should be done? Fix formatting or loosen the rules?

[jramosss]

First of all maybe change the name of the issue to fix formatting issues.
Then, definitely loosen the rules, unless the philosophy of the repo is to use docstring (maybe in core/big functions helps, but i don't think every function should have a docstring)
I created a new one, see #67

[Averagenormaljoe]

Is this still being worked on?

[peterdudfield]

your welcome to work on this @Averagenormaljoe

[Averagenormaljoe]

Thank you, I will start working on this now.

[Averagenormaljoe]

Relating to the docstring issue, should we make docstrings optional or have every function use a docstring? @peterdudfield

[peterdudfield]

every function should have a docstring in my opinion

[Averagenormaljoe]

Thank you, and another question: the error log mentions errors that certain lines in the docstrings for the summary (the first line in the docstring) are longer than 100 characters; however, when split into another line, it is then treated as a description, and it says there should be space between them. Should the docstring summary length be reduced, or would a different approach be preferred?

The error message regarding docstring length:

::error title=Ruff (E501),file=metnet\metnet\layers\ConvGRU.py,line=115,col=101,endLine=115,endColumn=111::metnet\layers\ConvGRU.py:115:101: E501 Line too long (110 > 100 characters)

[Averagenormaljoe]

In addition, Ruff mentioned that it was unable to detect undefined names in the "init.py" file due to imports being implicitly defined with "*' for "from .layers import *". One option would be to explicitly define the imported functions. What would be the preferred approach? @peterdudfield

The Ruff error message:

::error title=Ruff (F403),file=/code/metnet/__init__.py,line=5,col=1,endLine=5,endColumn=22::metnet/__init__.py:5:1: F403 'from .layers import *' used; unable to detect undefined names