Skip to content

Commit 77c41ce

Browse files
authored
Merge pull request #518 from openclimatefix/claude/skill-note-closing-issue-refs
Note the sticky closing-issue links in the PR-workflow skill
2 parents 8f39894 + ade9dd8 commit 77c41ce

1 file changed

Lines changed: 17 additions & 0 deletions

File tree

  • .claude/skills/github-issue-pr-workflow

.claude/skills/github-issue-pr-workflow/SKILL.md

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,23 @@ Never squash-merge. Jack wants the full commit history preserved in `main`, so u
5050
(`gh pr merge --merge`) or rebase (`gh pr merge --rebase`), not `gh pr merge --squash`. Under the
5151
`implement-issue` routine you stop and wait for Jack's review rather than merging at all.
5252

53+
**Check what the merge will close, before you merge:**
54+
55+
```bash
56+
gh pr view <N> --json closingIssuesReferences --jq '.closingIssuesReferences[].number'
57+
```
58+
59+
Every number listed is closed the moment the PR merges. The list is *sticky*: a closing keyword
60+
in an early draft of the PR body, or in any commit message on the branch, registers the link
61+
permanently, and later editing that text away does not remove it. So a PR whose body now says
62+
"filed rather than fixed, see #512" can still be holding a closing link to #512 from a draft —
63+
reading the current body is not enough, and neither is grepping the commits.
64+
65+
If the list contains an issue you did not mean to close, either sort it out before merging or
66+
watch for it afterwards: `gh issue reopen <N>`, then put its project Status back (the board
67+
automation moves a closed issue to Done, and reopening it lands on In Progress, not Todo — see
68+
the `github-graphql` skill for `gh project item-edit`).
69+
5370
## GraphQL calls
5471

5572
Attaching and reordering sub-issues, setting an issue's Type, and setting a project field all need

0 commit comments

Comments
 (0)