Note the sticky closing-issue links in the PR-workflow skill - #517
Closed
JackKelly wants to merge 1 commit into
Closed
Note the sticky closing-issue links in the PR-workflow skill#517JackKelly wants to merge 1 commit into
JackKelly wants to merge 1 commit into
Conversation
Merging PR #514 closed #512, which its body said had been filed rather than fixed. The link came from an earlier draft of the body: GitHub registers a closing reference when the text is first saved and keeps it after the text is edited away, so neither the current body nor the branch's commit messages show it. `gh pr view <N> --json closingIssuesReferences` is the only thing that does. Also records the recovery, since reopening is not the whole of it: the board automation moves a closed issue to Done, and a reopen lands on In Progress rather than Todo. Co-Authored-By: Claude <noreply@anthropic.com>
Member
Author
|
Superseded: this PR's first body used a closing keyword next to the issue reference and so registered a closing link that a body edit would not clear. Reopening as a fresh PR from the same branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a "check what the merge will close" step to the
github-issue-pr-workflowskill.Why
Issue #512 was closed by
the merge of #514 — a PR
that had deliberately left it alone, and whose body said so ("Two things noticed in passing, filed
rather than fixed"). It has since been reopened, with its project Status put back to Todo.
The cause is that a closing reference is sticky. GitHub registers the link when the text
containing the keyword is first saved, and does not remove it when the text is edited away.
An early draft of #514's body must have said "closes #512"; by merge time no trace of that
remained in either the body or the branch's five commit messages, but the link was still live:
So the check has to be that field. Reading the body is not evidence, and neither is grepping the
commits.
What the note says
The command to run before
gh pr merge, why the current body cannot be trusted, and how torecover — because reopening is not the whole of it. The board automation moves a closed issue to
Done, and a reopen lands it on In Progress, not back on Todo, so the project field needs
setting explicitly.