Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README to include Met Office and ECMWF NWPs #795

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lambaaryan011
Copy link

Pull Request

Description

This PR updates the infrastructure to support pulling Numerical Weather Predictions (NWPs) from both the Met Office and ECMWF. This enhancement ensures broader and more comprehensive weather data availability for nowcasting and forecasting applications.
Fixes #467

How Has This Been Tested?

⇾ Verified data integration from both Met Office and ECMWF sources.
⇾ Ensured compatibility with existing nowcasting infrastructure.
⇾ Ran Terraform validation to confirm no deployment issues.

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-requested a review February 19, 2025 19:28
@peterdudfield
Copy link
Contributor

Would you be able to update the readme here and here

@peterdudfield
Copy link
Contributor

logs are at /aws/ecs/consumer/nwp-consumer-ecmwf-uk and the variables are stated here

@lambaaryan011
Copy link
Author

lambaaryan011 commented Feb 19, 2025

Would you be able to update the readme here and here

Should I update in this doc also . Or something else. And can you explain these thing in details

@lambaaryan011
Copy link
Author

Hey @peterdudfield i complete all change that you tell. So, can you have a look.

@lambaaryan011
Copy link
Author

Hey @peterdudfield i complete all the change that you told me. So have a look

@lambaaryan011
Copy link
Author

@peterdudfield have a look .from last week this is pending so can you review it

@peterdudfield
Copy link
Contributor

@devsjc you ok to look at this?

@peterdudfield peterdudfield requested a review from devsjc March 3, 2025 15:01
Copy link
Collaborator

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lambaaryan011 !

@lambaaryan011
Copy link
Author

@peterdudfield can you review this ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update nwp in readme.md
3 participants