Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15 min filecheck added #783

Merged
merged 7 commits into from
Feb 12, 2025
Merged

15 min filecheck added #783

merged 7 commits into from
Feb 12, 2025

Conversation

aryanbhosale
Copy link
Member

Pull Request

Description

pipeline will check both the 5-minute and 15-minute satellite files each run, and will fail early and alert Slack if one is missing

Fixes #764

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@aryanbhosale
Copy link
Member Author

@peterdudfield is this what you were looking for?

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this, on i left a comment which should help

Copy link
Contributor

@peterdudfield peterdudfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, just one small change

"but the satellite consumer should also do this. "
"No out of office hours support is required."
satellite_both_files_missing_error_message = (
"⚠️ Tried to update the latest Satellite data, but could not find "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You ok to update this, then I think its ready to go

Tried to update the database to show when the latest satellite data was collected, but could not find the 5-min or the 15-min satellite files.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You ok to update this, then I think its ready to go

Tried to update the database to show when the latest satellite data was collected, but could not find the 5-min or the 15-min satellite files.

done

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i cant see this change

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to update the database to show when the latest satellite data was collected, but could not find the 5-min or the 15-min satellite files.

my bad updated it with the wrong thing, you should see it now

@peterdudfield
Copy link
Contributor

Happy for me to merge?

@aryanbhosale
Copy link
Member Author

Happy for me to merge?

Yes I'm happy with this

@peterdudfield peterdudfield merged commit 8e5bcf3 into main Feb 12, 2025
5 checks passed
@peterdudfield peterdudfield deleted the sat-15-min-filecheck branch February 12, 2025 12:17
@peterdudfield peterdudfield mentioned this pull request Feb 26, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Satellite 15 minute file check
2 participants