Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always run ECMWF only model #799

Open
peterdudfield opened this issue Feb 24, 2025 · 7 comments
Open

Always run ECMWF only model #799

peterdudfield opened this issue Feb 24, 2025 · 7 comments
Assignees

Comments

@peterdudfield
Copy link
Contributor

Detailed Description

On forecast dag run, run ecmwf model all the time.

Context

  • currently it only runs if pvnet main fails

Possible Implementation

@peterdudfield peterdudfield added enhancement New feature or request good first issue Good for newcomers contributions-welcome and removed enhancement New feature or request labels Feb 24, 2025
@felix-se-cat
Copy link
Contributor

Happy to work on this, if you can assign me please?

@peterdudfield
Copy link
Contributor Author

That would be great. Can I add something in. So if the environment is development, can we not run this, but on production we should always run pvnet ecwmf model.

@felix-se-cat
Copy link
Contributor

Just to clarify from your comment, if environment is production always run pvnet ecwmf (i.e. the original change request). If environment is development do want want to maintain the current approach or simply never run ecwmf?

@peterdudfield
Copy link
Contributor Author

Actually lets hold fire on this. With some discussion with @dfulu I think we could do this in the uk-pvnet-app

@peterdudfield
Copy link
Contributor Author

Follows on from openclimatefix/uk-pvnet-app#264

@felix-se-cat
Copy link
Contributor

felix-se-cat commented Feb 27, 2025

So no changes needed here just yet?
I could look into #264 that you have linked above, but would also understand if you'd rather have someone else on it, given that I am fairly new.
I would probably need to ask about 500 questions.

@peterdudfield
Copy link
Contributor Author

@dfulu is currently doing a bit of a refactoring of Pvnet-app, so it might be better to wait until after that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants