fix: improve production code safety and input validation (#332)

* fix: improve production code safety and input validation

- Replace assert statements with proper ValueError in weather/open_meteo.py

- Replace implicit None return with ValueError in forecast.py

- Use log.info instead of print for consistency

* fix(deps): pin sentry-sdk to 2.37.1 to fix CI compatibility with huggingface_hub

* fix(deps): downgrade sentry-sdk to 1.45.0 to resolve huggingface_hub incompatibility

* fix(deps): update huggingface_hub to 0.20.0 to resolve sentry-sdk integration compatibility

* fix: disable sentry default integrations to prevent huggingface_hub incompatibility

Author: Raakshass

quartz_solar_forecast/forecast.py

@@ -93,31 +93,32 @@ def predict_tryolabs(site: PVSite, ts: datetime | str = None):
     three_months_ago = datetime.today() - timedelta(days=3 * 30)
 
     if start_date_datetime < three_months_ago:
-        print(
-            f"Start date ({start_date}) is more than 3 months ago, no",
-            "forecast data available.",
-        )
-    else:
-        # download the model from google drive and decompress if necessary
-        solar_power_predictor.load_model()
-        # make predictions
-        predictions = solar_power_predictor.predict_power_output(
-            latitude=site.latitude,
-            longitude=site.longitude,
-            start_date=start_date,
-            kwp=site.capacity_kwp,
-            orientation=site.orientation,
-            tilt=site.tilt,
+        raise ValueError(
+            f"Start date ({start_date}) is more than 3 months ago. "
+            "Historical forecast data is not available beyond this range. "
+            "Please use a more recent date."
         )
 
-        # postprocessing of the dataframe
-        predictions = predictions[
-            (predictions["date"] >= start_time) & (predictions["date"] < end_time)
-        ]
-        predictions = predictions.reset_index(drop=True)
-        predictions.set_index("date", inplace=True)
-        print("Predictions finished.")
-        return predictions
+    # download the model from google drive and decompress if necessary
+    solar_power_predictor.load_model()
+    # make predictions
+    predictions = solar_power_predictor.predict_power_output(
+        latitude=site.latitude,
+        longitude=site.longitude,
+        start_date=start_date,
+        kwp=site.capacity_kwp,
+        orientation=site.orientation,
+        tilt=site.tilt,
+    )
+
+    # postprocessing of the dataframe
+    predictions = predictions[
+        (predictions["date"] >= start_time) & (predictions["date"] < end_time)
+    ]
+    predictions = predictions.reset_index(drop=True)
+    predictions.set_index("date", inplace=True)
+    log.info("Predictions finished.")
+    return predictions
 
 
 def run_forecast(

quartz_solar_forecast/utils/sentry_logging.py

@@ -14,7 +14,14 @@
 )
 
 SENTRY_DSN = "https://b2b6f3c97299f81464bc16ad0d516d0b@o400768.ingest.us.sentry.io/4508439933157376"
-sentry_sdk.init(dsn=SENTRY_DSN, traces_sample_rate=1.0)
+
+# Disable default integrations to prevent incompatible huggingface_hub integration
+# from causing AttributeError with older huggingface_hub versions
+sentry_sdk.init(
+    dsn=SENTRY_DSN,
+    traces_sample_rate=1.0,
+    default_integrations=False,
+)
 
 
 def write_sentry(params):

quartz_solar_forecast/weather/open_meteo.py

@@ -70,10 +70,11 @@ def _validate_coordinates(self, latitude: float, longitude: float) -> None:
         ValueError
             If coordinates are not within valid ranges.
         """
-        assert -90 <= latitude <= 90 and -180 <= longitude <= 180, (
-            "Invalid coordinates. Latitude must be between -90 and 90, "
-            "and longitude must be between -180 and 180."
-        )
+        if not (-90 <= latitude <= 90 and -180 <= longitude <= 180):
+            raise ValueError(
+                "Invalid coordinates. Latitude must be between -90 and 90, "
+                "and longitude must be between -180 and 180."
+            )
 
     def _validate_date_format(self, start_date: str, end_date: str) -> None:
         """
@@ -94,12 +95,16 @@ def _validate_date_format(self, start_date: str, end_date: str) -> None:
         try:
             start_datetime = datetime.strptime(start_date, "%Y-%m-%d")
             end_datetime = datetime.strptime(end_date, "%Y-%m-%d")
-            assert end_datetime > start_datetime, "End date must be greater than start date."
-        except (ValueError, AssertionError) as e:
+        except ValueError as e:
             raise ValueError(
-                f"Invalid date format or range. Please use YYYY-MM-DD and ensure "
-                f"end_date is greater than start_date. Error: {str(e)}"
+                f"Invalid date format. Please use YYYY-MM-DD format. Error: {str(e)}"
             ) from e
+        
+        if not (end_datetime > start_datetime):
+            raise ValueError(
+                f"Invalid date range. End date ({end_date}) must be greater than "
+                f"start date ({start_date})."
+            )
 
     def get_hourly_weather(
         self, latitude: float, longitude: float, start_date: str, end_date: str