Merge pull request #471 from openclimatefix/india-mvp

India MVP

Author: braddf

.github/workflows/yarn_test.yaml

@@ -17,11 +17,15 @@ jobs:
       uses: actions/setup-node@v3
       with:
         node-version: ${{ matrix.node-version }}
-    - name: install yarn app
+    - name: install yarn
       run: |
         cd apps/nowcasting-app
         yarn install
+    - name: build & start app
+      run: |
+        cd apps/nowcasting-app
+        yarn build
     - name: run tests
       run: |
         cd apps/nowcasting-app
-        yarn test --coverage --coverageDirectory=../..
+        yarn start & sleep 5 && yarn test --coverage --coverageDirectory=../..

apps/nowcasting-app/components/charts/forecast-header/ui.tsx

@@ -1,4 +1,3 @@
-import React from "react";
 import { theme } from "../../../tailwind.config";
 import { ClockIcon } from "../../icons/icons";
 import ForecastLabel from "../../national_forecast_labels";
@@ -146,6 +145,7 @@ export const NextForecast: React.FC<{ pv: string; tip: string; time: string; col
 };
 
 type ForecastHeaderProps = {
+  children: React.ReactNode;
   forecastNextPV: string;
   forecastPV: string;
   actualPV: string;

apps/nowcasting-app/components/charts/gsp-pv-remix-chart/forecast-header-gsp.tsx

@@ -1,7 +1,7 @@
-import React from "react";
 import { CloseButtonIcon, DownArrow, UpArrow } from "../../icons/icons";
 import { ForecastHeadlineFigure } from "../forecast-header/ui";
 import { DeltaHeaderBlock } from "../delta-view/delta-header-block";
+import React, { FC } from "react";
 
 type ForecastHeaderGSPProps = {
   title: string;
@@ -14,9 +14,10 @@ type ForecastHeaderGSPProps = {
   forecastPV?: string;
   forecastNextTimeOnly?: string;
   forecastNextPV?: string;
+  children?: React.ReactNode;
 };
 
-const ForecastHeaderGSP: React.FC<ForecastHeaderGSPProps> = ({
+const ForecastHeaderGSP: FC<ForecastHeaderGSPProps> = ({
   title,
   deltaView,
   deltaValue,

apps/nowcasting-app/components/charts/gsp-pv-remix-chart/index.tsx

@@ -1,4 +1,3 @@
-import { FC } from "react";
 import RemixLine from "../remix-line";
 import useFormatChartData from "../use-format-chart-data";
 import {
@@ -12,6 +11,7 @@ import useGetGspData from "./use-get-gsp-data";
 import useGlobalState, { get30MinNow, getNext30MinSlot } from "../../helpers/globalState";
 import Spinner from "../../icons/spinner";
 import { ForecastValue } from "../../types";
+import React, { FC } from "react";
 
 // We want to have the ymax of the graph to be related to the capacity of the GspPvRemixChart
 // If we use the raw values, the graph looks funny, i.e y major ticks are 0 100 232

apps/nowcasting-app/components/charts/solar-site-view/forecast-header.tsx

@@ -1,4 +1,3 @@
-import React from "react";
 import { CloseButtonIcon } from "../../icons/icons";
 
 type ForecastHeaderSiteProps = {

apps/nowcasting-app/components/delta-forecast-label.tsx

@@ -1,4 +1,5 @@
 type DeltaForecastLabelProps = {
+  children: React.ReactNode;
   tip: string | React.ReactNode;
   position?: "left" | "right" | "middle";
   className?: string;

apps/nowcasting-app/components/helpers/utils.test.ts

@@ -25,8 +25,8 @@ describe("check getOpacityValueFromPVNormalized with valid values", () => {
 describe("check convertISODateStringToLondonTime", () => {
   test("check convertISODateStringToLondonTime with valid date strings", () => {
     expect(convertISODateStringToLondonTime("2021-01-01T03:00:00.000Z")).toBe("03:00");
-    expect(convertISODateStringToLondonTime("2021-01-01T03:21:00.000")).toBe("03:21");
-    expect(convertISODateStringToLondonTime("2021-01-01T03:50:11")).toBe("03:50");
+    expect(convertISODateStringToLondonTime("2021-01-01T03:21:00.000Z")).toBe("03:21");
+    expect(convertISODateStringToLondonTime("2021-01-01T03:50:11Z")).toBe("03:50");
   });
 
   it("should handle an empty date string", () => {

apps/nowcasting-app/components/icons/logo.tsx

@@ -1,4 +1,6 @@
-export const OCFlogo = () => (
+import { FC } from "react";
+
+export const OCFlogo: FC = () => (
   <a
     className="max-h-full z-20"
     href="https://www.openclimatefix.org/"

apps/nowcasting-app/components/layout/header/profile-dropdown.tsx

@@ -170,7 +170,7 @@ const ProfileDropDown = ({}: IProfileDropDown) => {
                   "block px-4 py-2 text-sm text-ocf-black-600"
                 )}
               >
-                <Link href="/api/auth/logout">
+                <Link href="/api/auth/logout" legacyBehavior>
                   <a id={"UserMenu-LogoutBtn"}>Sign out</a>
                 </Link>
               </div>

apps/nowcasting-app/components/map/types.ts

@@ -12,10 +12,10 @@ export enum SelectedData {
 }
 
 export interface IMap {
+  children: React.ReactNode;
   loadDataOverlay: any;
   controlOverlay: any;
   bearing?: number;
   updateData: { newData: boolean | string; updateMapData: (map: mapboxgl.Map) => void };
-  children: React.ReactNode;
   title: string;
 }