Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match Paper implementation closer #3

Closed
jacobbieker opened this issue Sep 24, 2021 · 0 comments · Fixed by #5
Closed

Match Paper implementation closer #3

jacobbieker opened this issue Sep 24, 2021 · 0 comments · Fixed by #5
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jacobbieker
Copy link
Member

Detailed Description

The paper's diagram of the model is this:

Nowcasting_Diagram

The implementation in this repo has three known differences.

  1. There is only a single G block between each ConvGRU
  2. Zsp input channels has to match the input channels from the conditioning stack, instead of the conditioning stack having half the channels of the latent space
  3. The number of channels from the 3x3 conditioning stack outputs does not exactly match the paper, and changes the number of channels to match the diagram.

Context

These differences could be important in training the model. While the current implementation is quite close and almost entirely follows the paper, these differences could be quite important.

@jacobbieker jacobbieker added enhancement New feature or request good first issue Good for newcomers labels Sep 24, 2021
@jacobbieker jacobbieker linked a pull request Oct 5, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant