Adding suggestions by Alexander

Author: adsha-quic

modules/fastcv/include/opencv2/fastcv/blur.hpp

@@ -65,8 +65,8 @@ CV_EXPORTS_W void sepFilter2D(InputArray _src, OutputArray _dst, int ddepth, Inp
  * @brief Calculates the local subtractive and contrastive normalization of the image.
  *        Each pixel of the image is normalized by the mean and standard deviation of the patch centred at the pixel.
  *        It is optimized for Qualcomm's processors.
- * @param src Input image, should have one channel CV_8U or CV_32F
- * @param dst Output array, should be one channel, CV_8S if src of type CV_8U, or CV_32F if src of CV_32F
+ * @param _src Input image, should have one channel CV_8U or CV_32F
+ * @param _dst Output array, should be one channel, CV_8S if src of type CV_8U, or CV_32F if src of CV_32F
  * @param pSize Patch size for mean and std dev calculation
  * @param useStdDev If 1, bot mean and std dev will be used for normalization, if 0, only mean used
  */

modules/fastcv/perf/perf_blur.cpp

@@ -125,7 +125,7 @@ typedef perf::TestBaseWithParam<tuple<Size, int, Size, int>> NormalizeLocalBoxPe
 PERF_TEST_P(NormalizeLocalBoxPerfTest, run,
     ::testing::Combine(::testing::Values(perf::szVGA, perf::sz720p, perf::sz1080p), // image size
                        ::testing::Values(CV_8U,CV_32F),                             // src image depth
-					   ::testing::Values(Size(3,3),Size(5,5)),                      // patch size
+                       ::testing::Values(Size(3,3),Size(5,5)),                      // patch size
                        ::testing::Values(0,1)                                       // use std dev or not
                        )
            )
@@ -140,12 +140,7 @@ PERF_TEST_P(NormalizeLocalBoxPerfTest, run,
     RNG& rng = cv::theRNG();
     cvtest::randUni(rng, src, Scalar::all(0), Scalar::all(255));
 
-    while (next())
-    {
-        startTimer();
-        cv::fastcv::normalizeLocalBox(src, dst, sz, useStdDev);
-        stopTimer();
-    }
+    TEST_CYCLE() cv::fastcv::normalizeLocalBox(src, dst, sz, useStdDev);
 
     SANITY_CHECK_NOTHING();
 }

modules/fastcv/src/blur.cpp

@@ -368,7 +368,7 @@ void normalizeLocalBox(InputArray _src, OutputArray _dst, Size pSize, bool useSt
     CV_Assert(type == CV_8UC1 || type == CV_32FC1);
 
     Size size = _src.size();
-    int dst_type = type == CV_8UC1 ? CV_8SC1 : CV_32FC1; 
+    int dst_type = type == CV_8UC1 ? CV_8SC1 : CV_32FC1;
     _dst.create(size, dst_type);
 
     Mat src = _src.getMat();

modules/fastcv/test/test_blur.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2024 Qualcomm Innovation Center, Inc. All rights reserved.
+ * Copyright (c) 2024-2025 Qualcomm Innovation Center, Inc. All rights reserved.
  * SPDX-License-Identifier: Apache-2.0
 */
 
@@ -108,6 +108,24 @@ TEST_P(SepFilter2DTest, accuracy)
     EXPECT_LT(num_diff_pixels, (src.rows+src.cols)*ksize);
 }
 
+typedef testing::TestWithParam<tuple<int>> NormalizeLocalBoxTest;
+
+TEST_P(NormalizeLocalBoxTest, accuracy)
+{
+    bool use_stddev = get<0>(GetParam());
+    cv::Mat src, dst;
+    src = imread(cvtest::findDataFile("cv/shared/baboon.png"), cv::IMREAD_GRAYSCALE);
+
+    cv::fastcv::normalizeLocalBox(src, dst, Size(5,5), use_stddev);
+    Scalar s = cv::mean(dst);
+
+    if(use_stddev)
+       EXPECT_LT(s[0],1);
+    else
+       EXPECT_LT(s[0],50);
+}
+
+
 INSTANTIATE_TEST_CASE_P(FastCV_Extension, GaussianBlurTest, Combine(
 /*image size*/     ::testing::Values(perf::szVGA, perf::sz720p, perf::sz1080p),
 /*image depth*/    ::testing::Values(CV_8U,CV_16S,CV_32S),
@@ -126,4 +144,7 @@ INSTANTIATE_TEST_CASE_P(FastCV_Extension, SepFilter2DTest, Combine(
 /*kernel size*/    Values(3, 5, 7, 9, 11)
 ));
 
+INSTANTIATE_TEST_CASE_P(FastCV_Extension, NormalizeLocalBoxTest, Values(0,1));
+
+
 }} // namespaces opencv_test, ::