Make __doRequest compatible with parent (#181)

oliubarskyi · web-flow · commit a0b164b16933 · 2023-04-25T08:30:45.000-07:00
From the documentation, https://www.php.net/manual/en/soapclient.dorequest.php returned value may be string or null. When this code is running with PHP 8.1 and null is returned the error `PHP Fatal error: Uncaught TypeError: ATWS\Client::__doRequest(): Return value must be of type string, null returned in /*******/vendor/opendns/autotask-php/src/Client.php:355` occurs.
diff --git a/src/Client.php b/src/Client.php
@@ -343,7 +343,7 @@ public function getInvoiceMarkup($invoiceId, $type)
         return $this->_call('GetInvoiceMarkup', array($invoiceMarkup));
     }
 
-    public function __doRequest($request, $location, $action, $version, $oneWay = 0): string
+    public function __doRequest($request, $location, $action, $version, $oneWay = 0): ?string
     {
         if (strpos($action, 'getZoneInfo') === false &&
             $this->version >= 1.6 &&

Original file line number	Diff line number	Diff line change
`@@ -343,7 +343,7 @@ public function getInvoiceMarkup($invoiceId, $type)`
`343`	`343`	`return $this->_call('GetInvoiceMarkup', array($invoiceMarkup));`
`344`	`344`	`}`
`345`	`345`
`346`		`- public function __doRequest($request, $location, $action, $version, $oneWay = 0): string`
	`346`	`+ public function __doRequest($request, $location, $action, $version, $oneWay = 0): ?string`
`347`	`347`	`{`
`348`	`348`	`if (strpos($action, 'getZoneInfo') === false &&`
`349`	`349`	`$this->version >= 1.6 &&`