Skip to content

Commit c76a7af

Browse files
authored
perf: optimizations for SortedModelSelect2Multiple.optgroups (#4538)
1 parent f238b3e commit c76a7af

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

course_discovery/apps/course_metadata/widgets.py

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -12,21 +12,17 @@ def optgroups(self, name, value, attrs=None):
1212
only support one main group (because that's all we need right now).
1313
"""
1414
selected = []
15-
unselected = []
1615
for index, (option_value, option_label) in enumerate(chain(self.choices)):
1716
is_selected = str(option_value) in value
18-
subgroup = [self.create_option(name, option_value, option_label, is_selected, index, attrs=attrs)]
19-
item = (None, subgroup, index)
2017
if is_selected:
18+
subgroup = [self.create_option(name, option_value, option_label, is_selected, index, attrs=attrs)]
19+
item = (None, subgroup, index)
2120
selected.append(item)
22-
else:
23-
unselected.append(item)
2421

2522
ordered = []
2623
for value_id in value:
2724
for item in selected:
2825
if value_id == str(item[1][0]['value']):
2926
ordered.append(item)
3027
break
31-
3228
return ordered

0 commit comments

Comments
 (0)