Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No ci in comit lint config #427

Closed
CodeWithEmad opened this issue Jun 7, 2024 · 1 comment
Closed

No ci in comit lint config #427

CodeWithEmad opened this issue Jun 7, 2024 · 1 comment

Comments

@CodeWithEmad
Copy link
Member

CodeWithEmad commented Jun 7, 2024

I noticed that commitlint config doesn't support ci.

https://github.com/openedx/edx-lint/blob/596689d8ef37616a073e5147a3d9e2af9f36a2b1/commitlint.config.js#L66C1-L66C104

Is there a reason behind it? @feanil @sarina

@feanil
Copy link
Contributor

feanil commented Jun 7, 2024

The full spec is here: https://docs.openedx.org/projects/openedx-proposals/en/latest/best-practices/oep-0051-bp-conventional-commits.html#specification

We support build and test instead which can be a bit more precise and useful.

@feanil feanil closed this as completed Jun 7, 2024
@github-project-automation github-project-automation bot moved this to Done in Arch-BOM Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants