fix: fix allocation math (#373)

Author: johnnagro

enterprise_access/apps/api/v1/tests/test_allocation_view.py

@@ -714,10 +714,11 @@ def test_allocate_too_much_subsidy_spend_e2e(
             'admin_users': [{'email': '[email protected]'}],
         }
 
-        subsidy_balance = 300
+        subsidy_balance = 1
         mock_subsidy_balance.return_value = subsidy_balance
+        # NOTE johnnagro this figure is no longer used in the math
         mock_aggregates_for_policy.return_value = {
-            'total_quantity': (subsidy_balance - 1) * -1,
+            'total_quantity': 0,
         }
 
         allocate_url = _allocation_url(self.assigned_learner_credit_policy.uuid)
@@ -795,10 +796,11 @@ def test_allocate_too_much_existing_allocation_e2e(
             'admin_users': [{'email': '[email protected]'}],
         }
 
-        subsidy_balance = 300
+        subsidy_balance = 1
         mock_subsidy_balance.return_value = subsidy_balance
+        # TODO johnnagro this figure is no longer used in the math
         mock_aggregates_for_policy.return_value = {
-            'total_quantity': (subsidy_balance - 1) * -1,
+            'total_quantity': 0,
         }
 
         allocate_url = _allocation_url(self.assigned_learner_credit_policy.uuid)

enterprise_access/apps/subsidy_access_policy/models.py

@@ -1275,15 +1275,15 @@ def can_allocate(self, number_of_learners, content_key, content_price_cents):
         # allocate won't exceed the remaining balance of the related subsidy.
         subsidy_balance = self.subsidy_balance()
         if self.content_would_exceed_limit(
-            total_allocated_and_spent_cents,
+            total_allocated_assignments_cents,
             subsidy_balance,
             positive_total_price_cents,
         ):
             logger.info(
                 f'content_would_exceed_limit function: '
                 f'subsidy_uuid={self.subsidy_uuid}, '
                 f'policy_uuid={self.uuid},'
-                f'total_allocated_and_spent_centers={total_allocated_and_spent_cents}, '
+                f'total_allocated_assignments_cents={total_allocated_assignments_cents}, '
                 f'subsidy_balance={subsidy_balance}, '
                 f'positive_total_price_cents={positive_total_price_cents}, '
             )

enterprise_access/apps/subsidy_access_policy/tests/test_models.py

@@ -1136,7 +1136,7 @@ def test_can_allocate_not_enough_subsidy_balance(self):
             },
         }
         self.mock_subsidy_client.list_subsidy_transactions.return_value = transactions_for_policy
-        self.mock_assignments_api.get_allocated_quantity_for_configuration.return_value = -500
+        self.mock_assignments_api.get_allocated_quantity_for_configuration.return_value = -1000
 
         # The balance of the subsidy is just a bit less
         # than the amount to potentially allocated, e.g.