Skip to content

Commit 5dca149

Browse files
authored
fix: peer review bug (#261)
* fix: resolve ORA peer review issue * fix: resolve visual glitch with validateBeforeConfirmation function * fix: update StepProgressIndicator Component
1 parent ad92c37 commit 5dca149

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

src/components/StepProgressIndicator/index.jsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ const StepProgressIndicator = ({ step }) => {
5353
&& !(step === stepNames.peer && stepInfo[step].isWaitingForSubmissions)
5454
&& !(step === stepNames.studentTraining && needed === done);
5555

56-
if (stepNames.peer === step && done >= needed) {
56+
if (loadNextAction?.action && stepNames.peer === step && done >= needed) {
5757
loadNextAction.action.labels.default = formatMessage(messages.gradeNextPeerOptional);
5858
}
5959
return (

src/views/SubmissionView/hooks/useSubmissionValidationStatus.js

+1-1
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ const useSubmissionStatuses = (textResponses, uploadedFiles) => {
3535
}
3636
const calcFileUploadIsRequired = submissionConfig.fileResponseConfig.required && !uploadedFiles.length;
3737
setFileUploadIsRequired(calcFileUploadIsRequired);
38+
setPromptStatuses(retrievePromptsSubmissionStatus);
3839
if (containsInvalidPrompts || (submissionConfig.fileResponseConfig.required && !uploadedFiles.length)) {
39-
setPromptStatuses(retrievePromptsSubmissionStatus);
4040
return false;
4141
}
4242

0 commit comments

Comments
 (0)