Skip to content

Commit 701d14f

Browse files
authored
Merge pull request #121 from edx/mikix/pageroute
docs: use PageRoute over Route in examples and docs
2 parents 0c89f25 + 67735be commit 701d14f

File tree

2 files changed

+6
-7
lines changed

2 files changed

+6
-7
lines changed

example/index.jsx

+3-4
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,7 @@ import 'babel-polyfill'; // eslint-disable-line import/no-extraneous-dependencie
22

33
import React from 'react';
44
import ReactDOM from 'react-dom';
5-
import { Route } from 'react-router-dom';
6-
import { AppProvider, ErrorPage, AuthenticatedPageRoute } from '@edx/frontend-platform/react';
5+
import { AppProvider, AuthenticatedPageRoute, ErrorPage, PageRoute } from '@edx/frontend-platform/react';
76
import { APP_INIT_ERROR, APP_READY, initialize } from '@edx/frontend-platform';
87
import { subscribe } from '@edx/frontend-platform/pubSub';
98

@@ -14,8 +13,8 @@ import AuthenticatedPage from './AuthenticatedPage';
1413
subscribe(APP_READY, () => {
1514
ReactDOM.render(
1615
<AppProvider>
17-
<Route exact path="/" component={ExamplePage} />
18-
<Route
16+
<PageRoute exact path="/" component={ExamplePage} />
17+
<PageRoute
1918
exact
2019
path="/error_example"
2120
component={() =>

src/initialize.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,18 @@
1111
* APP_READY,
1212
* subscribe,
1313
* } from '@edx/frontend-platform';
14-
* import { ErrorPage, AppProvider } from '@edx/frontend-platform/react';
14+
* import { AppProvider, ErrorPage, PageRoute } from '@edx/frontend-platform/react';
1515
* import React from 'react';
1616
* import ReactDOM from 'react-dom';
17-
* import { Route, Switch } from 'react-router-dom';
17+
* import { Switch } from 'react-router-dom';
1818
*
1919
* subscribe(APP_READY, () => {
2020
* ReactDOM.render(
2121
* <AppProvider store={configureStore()}>
2222
* <Header />
2323
* <main>
2424
* <Switch>
25-
* <Route exact path="/" component={PaymentPage} />
25+
* <PageRoute exact path="/" component={PaymentPage} />
2626
* </Switch>
2727
* </main>
2828
* <Footer />

0 commit comments

Comments
 (0)