Skip to content

Commit 82b3df0

Browse files
committed
fix: update dependenices and AppProvider test
1 parent 383979d commit 82b3df0

File tree

6 files changed

+54
-10
lines changed

6 files changed

+54
-10
lines changed

package-lock.json

Lines changed: 29 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,14 +35,16 @@
3535
"devDependencies": {
3636
"@edx/brand": "npm:@openedx/brand-openedx@^1.2.2",
3737
"@edx/browserslist-config": "1.2.0",
38-
"@openedx/frontend-build": "14.0.3",
39-
"@openedx/paragon": "22.3.2",
38+
"@openedx/frontend-build": "github:edunext/frontend-build#dcoa/design-tokens-support",
39+
"@openedx/paragon": "npm:@openedx/paragon@^22.0.0-alpha.25",
4040
"@testing-library/jest-dom": "6.4.5",
4141
"@testing-library/react": "12.1.5",
4242
"@testing-library/react-hooks": "^8.0.1",
43+
"@testing-library/user-event": "14.4.3",
4344
"axios-mock-adapter": "^1.21.3",
4445
"core-js": "3.37.0",
4546
"husky": "8.0.3",
47+
"jest-localstorage-mock": "^2.4.26",
4648
"jsdoc": "^4.0.0",
4749
"nodemon": "3.1.0",
4850
"prop-types": "15.8.1",

src/react/AppProvider.test.jsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import React from 'react';
22
import { createStore } from 'redux';
33
import { render, screen } from '@testing-library/react';
44
import userEvent from '@testing-library/user-event';
5-
import '@testing-library/jest-dom/extend-expect';
5+
import '@testing-library/jest-dom';
66

77
import AppProvider from './AppProvider';
88
import { initialize } from '../initialize';
@@ -32,6 +32,7 @@ jest.mock('../config', () => ({
3232
REFRESH_ACCESS_TOKEN_ENDPOINT: 'localhost:18000/oauth2/access_token',
3333
ACCESS_TOKEN_COOKIE_NAME: 'access_token',
3434
CSRF_TOKEN_API_PATH: 'localhost:18000/csrf',
35+
PUBLIC_PATH: '/',
3536
}),
3637
}));
3738

src/react/hooks/paragon/useParagonThemeCore.js

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,9 @@ const useParagonThemeCore = ({
3434
setIsBrandThemeCoreLoaded(true);
3535
return;
3636
}
37-
const getParagonThemeCoreLink = () => document.head.querySelector('link[data-paragon-theme-core="true"');
37+
const getParagonThemeCoreLink = () => document.head.querySelector('link[data-paragon-theme-core="true"]');
3838
const existingCoreThemeLink = document.head.querySelector(`link[href='${themeCore.urls.default}']`);
39+
const brandCoreLink = document.head.querySelector(`link[href='${themeCore.urls.brandOverride}']`);
3940
if (!existingCoreThemeLink) {
4041
const getExistingCoreThemeLinks = (isBrandOverride) => {
4142
const coreThemeLinkSelector = `link[data-${isBrandOverride ? 'brand' : 'paragon'}-theme-core="true"]`;
@@ -126,6 +127,15 @@ const useParagonThemeCore = ({
126127
} else {
127128
setIsBrandThemeCoreLoaded(true);
128129
}
130+
} else {
131+
existingCoreThemeLink.rel = 'stylesheet';
132+
existingCoreThemeLink.removeAttribute('as');
133+
if (brandCoreLink) {
134+
brandCoreLink.rel = 'stylesheet';
135+
brandCoreLink.removeAttribute('as');
136+
}
137+
setIsParagonThemeCoreLoaded(true);
138+
setIsBrandThemeCoreLoaded(true);
129139
}
130140
}, [themeCore?.urls, onLoad]);
131141
};

src/react/hooks/paragon/useParagonThemeVariants.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,13 @@ const useParagonThemeVariants = ({
187187
} else {
188188
const updatedStylesheetRel = generateStylesheetRelAttr(themeVariant);
189189
existingThemeVariantLink.rel = updatedStylesheetRel;
190-
existingThemeVariantBrandLink.rel = updatedStylesheetRel;
190+
existingThemeVariantLink.removeAttribute('as');
191+
if (existingThemeVariantBrandLink) {
192+
existingThemeVariantBrandLink.rel = updatedStylesheetRel;
193+
existingThemeVariantBrandLink.removeAttribute('as');
194+
}
195+
setIsParagonThemeVariantLoaded(true);
196+
setIsBrandThemeVariantLoaded(true);
191197
}
192198
});
193199
}, [themeVariants, currentThemeVariant, onLoad]);

src/setupTest.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
import 'core-js/stable';
33
import 'regenerator-runtime/runtime';
44
import '@testing-library/jest-dom';
5+
import 'jest-localstorage-mock';
56

67
// These configuration values are usually set in webpack's EnvironmentPlugin however
78
// Jest does not use webpack so we need to set these so for testing

0 commit comments

Comments
 (0)