-
Notifications
You must be signed in to change notification settings - Fork 69
fix: create the brand fallback for {} PARAGON_THEME_URLS #785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: create the brand fallback for {} PARAGON_THEME_URLS #785
Conversation
…RAGON_THEMES_URLS
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #785 +/- ##
==========================================
+ Coverage 86.71% 86.78% +0.06%
==========================================
Files 48 48
Lines 1393 1400 +7
Branches 293 297 +4
==========================================
+ Hits 1208 1215 +7
Misses 172 172
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Left a small comment with a clarifying question, but it's definitely non-blocking.
const localParagonCoreUrl = PARAGON_THEME?.paragon?.themeUrls?.core; | ||
const localParagonThemeVariants = PARAGON_THEME?.paragon?.themeUrls?.variants; | ||
const localParagonDefaultThemeVariants = PARAGON_THEME?.paragon?.themeUrls?.defaults; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure I'm understanding this:
- Before this we were assuming we had
PARAGON_THEME
but not assuming we hadPARAGON_THEME.paragon
- With this we are not assuming we have
PARAGON_THEME
This is to handle PARAGON_THEME
being undefined
(as it is with the test change) correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is to handle PARAGON_THEME being undefined (as it is with the test change) correct?
Yes, it is
Description:
If the brand package is installed with a compatible version of design tokens and define
PARAGON_THEMES_URLS={}
to use the local files, this one is not creating the corresponding urls - only the Paragon default ones. This PR aims to add the logic to permit the creation of those urls.I added some improvements in the test file based on the comments of the original PR #689 (comment)
Merge checklist:
frontend-platform
. This can be done by runningnpm start
and opening http://localhost:8080.module.config.js
file infrontend-build
.fix
,feat
) and is appropriate for your code change. Consider whether your code is a breaking change, and modify your commit accordingly.Post merge: