Skip to content

Conversation

@BryanttV
Copy link
Contributor

@BryanttV BryanttV commented Nov 25, 2025

Description

This PR updates the current enforcement unit tests to fix test cases involving the global scope. It's always necessary to include the scope with the namespace, in this case, global.

- "scope": "*",
+ "scope": make_scope_key("global", GLOBAL_SCOPE_WILDCARD),

Error Detail

==================================================================== short test summary info ====================================================================
FAILED openedx_authz/tests/test_enforcement.py::SystemWideRoleTests::test_platform_admin_general_access_1 - ValueError: Invalid namespaced_key format: *
FAILED openedx_authz/tests/test_enforcement.py::WildcardScopeTests::test_wildcard_course_access_1_______False_ - ValueError: Invalid namespaced_key format: *
FAILED openedx_authz/tests/test_enforcement.py::WildcardScopeTests::test_wildcard_global_access_1_______True_ - ValueError: Invalid namespaced_key format: *
FAILED openedx_authz/tests/test_enforcement.py::WildcardScopeTests::test_wildcard_library_access_1_______False_ - ValueError: Invalid namespaced_key format: *
FAILED openedx_authz/tests/test_enforcement.py::WildcardScopeTests::test_wildcard_org_access_1_______False_ - ValueError: Invalid namespaced_key format: *

Merge checklist:

Check off if complete or not applicable:

  • Version bumped
  • Changelog record added
  • Documentation updated (not only docstrings)
  • Fixup commits are squashed away
  • Unit tests added/updated
  • Manual testing instructions provided
  • Noted any: Concerns, dependencies, migration issues, deadlines, tickets

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Nov 25, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Nov 25, 2025

Thanks for the pull request, @BryanttV!

This repository is currently maintained by @openedx/committers-openedx-authz.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@BryanttV BryanttV force-pushed the bav/fix-tests-with-global-scope branch from 73e762f to 95d1234 Compare November 25, 2025 15:59
@BryanttV BryanttV marked this pull request as ready for review November 25, 2025 16:11
Copy link
Contributor

@bmtcril bmtcril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this!

Copy link
Member

@mariajgrimaldi mariajgrimaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@mariajgrimaldi mariajgrimaldi merged commit 9a9ab05 into openedx:main Nov 25, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in Contributions Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants