-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [FC-0074] add static type checking for documentation purposes #250
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
03ef552
to
bd7b71e
Compare
105a7ac
to
35ffa69
Compare
bd7b71e
to
8996b91
Compare
1d2c8a1
to
ea1b74b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with using mypy for typing but this looks good and well-documented to me.
Description
This PR supports mypy based on what's already implemented for the filter tooling. The aim is to gradually start refactoring the library so it's more type-aware by starting to type what's currently here without any modifications to the codebase, mainly changing method signatures.
Testing instructions
You can run
tox -e quality
or review the workflow run here: https://github.com/openedx/openedx-filters/actions/runs/13133404193/job/36643330405?pr=250#step:6:29Deadline
"None" if there's no rush, or provide a specific date or event (and reason) if there is one.
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.