-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: [FC-0074] include tooling in references #253
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @mariajgrimaldi! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.
|
b96b29c
to
2c6662c
Compare
Another version would be: | ||
|
||
class MyFilterStep(PipelineStep): | ||
Another version would be: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Thanks!
openedx_filters/learning/filters.py
Outdated
Initialize the exception with the message and the template to render instead. | ||
|
||
Arguments: | ||
message (Str): error message for the exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
message (Str): error message for the exception. | |
message (str): error message for the exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Description
This PR includes references to filter tooling, making it easier for developers to find it while reading the documentation.
Testing instructions
You can see the rendered docs here: https://docsopenedxorg--253.org.readthedocs.build/projects/openedx-filters/en/253/reference/filters-tooling.html
Deadline
None
Checklists
Check off if complete or not applicable:
Merge Checklist:
Post Merge:
finished.