Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Integration Issues After Transition to MFEs #255

Open
mariajgrimaldi opened this issue Jan 24, 2025 · 1 comment
Open

Filter Integration Issues After Transition to MFEs #255

mariajgrimaldi opened this issue Jan 24, 2025 · 1 comment
Assignees

Comments

@mariajgrimaldi
Copy link
Member

Some filters are not functioning correctly after transitioning from Django legacy views to MFEs. Here are a few examples found during testing with the openedx-filters-samples repository when trying to halt the registration, login and unenrollment:

  • StudentRegistrationRequested: when a user’s registration is halted, no feedback is provided to the user. Although the registration is successfully blocked, users can only see the reason by inspecting the network console.

Image

  • StudentLoginRequested: when a user’s login is halted, the interface displays a generic error message stating "an error occurred." The message doesn’t explain why the login failed or what went wrong.

Image

  • CourseUnenrollmentStarted: when an unenrollment is halted, the frontend incorrectly shows that the unenrollment was successful, even though it wasn't because of the exception raised by the filter. The unenrollment doesn’t complete as it should, but this isn’t reflected in the UI.

  • CertificateCreationRequested: the UI fails completely in a development environment, showing a 400 AxiosError with no useful feedback.

Image

These issues result in a confusing user experience, as users cannot understand why their actions are blocked. Improving the feedback provided by these filters is crucial for better clarity and consistency.

@mariajgrimaldi
Copy link
Member Author

This also raises the question of how to better test this kind of integration so that these breaking changes aren't overlooked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant