Skip to content

Conversation

@dwong2708
Copy link
Contributor

@dwong2708 dwong2708 commented Dec 3, 2025

Resolves: #446

Updates:

  • Removed the created_by serializer field because it is no longer necessary for serialization, although still required for entity/collection creation.
  • Updated logic so created_by reflects the user executing the restore operation rather than the user who created the backup.
  • Added unit tests to validate the updated behavior.

Result:

image

@openedx-webhooks
Copy link

openedx-webhooks commented Dec 3, 2025

Thanks for the pull request, @dwong2708!

This repository is currently maintained by @axim-engineering.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 3, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Dec 3, 2025
@dwong2708 dwong2708 marked this pull request as ready for review December 3, 2025 19:16
@dwong2708 dwong2708 requested a review from ormsbee December 3, 2025 19:34
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Dec 3, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Dec 3, 2025
@ormsbee ormsbee moved this from Ready for Review to In Eng Review in Contributions Dec 4, 2025
def __init__(self, zipf: zipfile.ZipFile, key: str | None = None, user: UserType | None = None):
self.zipf = zipf
self.user = user
self.user_id = getattr(self.user, "id", None)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future PRs: You can use the AnonymousUser if you need a user that has no ID but can still be used for things like permissions checks.

@ormsbee ormsbee merged commit 5f22b59 into openedx:main Dec 4, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from In Eng Review to Done in Contributions Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[Backup & Restore LibV2] Register the user who performs a library restore

4 participants