Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Searchbar to be a search-a-licious gobal component, and make a simple search-bar component #282

Open
alexgarel opened this issue Mar 7, 2025 · 0 comments
Open

Change Searchbar to be a search-a-licious gobal component, and make a simple search-bar component #282

alexgarel opened this issue Mar 7, 2025 · 0 comments
Labels
frontend

Comments

@alexgarel
Copy link
Member

We currently a lot of the implementation inside searchbar.

But this is an anti-pattern because it force using this component everywhere.

  1. create a searchalicious component that contains all the configuration and is responsible for handling all the state around research queries (it's the one talking tot the backend)
  2. make searchalicious-bar a simpler component that delegate the search action to searchalicious

Better do it in conjunction with #275
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
frontend
Projects
🔎 Search-a-licious
Status: Backlog (ready for dev)
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alexgarel