Shutdown 'unchanged files' code warnings that show up in PRs

Author: nirvn

src/core/valuemapmodelbase.cpp

@@ -37,7 +37,7 @@ void ValueMapModelBase::setMap( const QVariant &map )
   const QVariantList list = map.toList();
   if ( !list.empty() ) // QGIS 3
   {
-    beginInsertRows( QModelIndex(), 0, list.size() - 1 );
+    beginInsertRows( QModelIndex(), 0, static_cast<int>( list.size() ) - 1 );
 
     for ( const QVariant &item : list )
     {

src/core/vertexmodel.cpp

@@ -144,7 +144,7 @@ void VertexModel::undoHistory()
       {
         setCurrentVertexIndex( -1 );
         beginResetModel();
-        mVertices.insert( std::max( 0, change.index - 1 ), change.vertex );
+        mVertices.insert( std::max<long long int>( change.index - 1, 0 ), change.vertex );
         createCandidates();
         endResetModel();
         setCurrentVertexIndex( change.index );
@@ -246,7 +246,7 @@ void VertexModel::createCandidates()
                                    []( const Vertex &vertex ) { return vertex.type != ExistingVertex; } ),
                    mVertices.end() );
 
-  int r = 0;
+  qsizetype r = 0;
 
   while ( r < mVertices.count() )
   {
@@ -382,7 +382,7 @@ QModelIndex VertexModel::parent( const QModelIndex &child ) const
 int VertexModel::rowCount( const QModelIndex &parent ) const
 {
   Q_UNUSED( parent )
-  return mVertices.count();
+  return static_cast<int>( mVertices.count() );
 }
 
 int VertexModel::columnCount( const QModelIndex &parent ) const
@@ -732,7 +732,7 @@ void VertexModel::setCurrentPoint( const QgsPoint &point )
   emit geometryChanged();
 }
 
-void VertexModel::setCurrentVertex( int newVertex, bool forceUpdate )
+void VertexModel::setCurrentVertex( qsizetype newVertex, bool forceUpdate )
 {
   if ( mCurrentIndex >= 0 && mCurrentIndex < mVertices.count() )
   {
@@ -768,7 +768,7 @@ void VertexModel::setCurrentVertex( int newVertex, bool forceUpdate )
   emit currentVertexIndexChanged();
 }
 
-void VertexModel::setCurrentVertexIndex( int currentIndex )
+void VertexModel::setCurrentVertexIndex( qsizetype currentIndex )
 {
   if ( currentIndex == mCurrentIndex )
     return;
@@ -786,7 +786,7 @@ int VertexModel::currentVertexIndex() const
 
 int VertexModel::vertexCount() const
 {
-  return mVertices.count();
+  return static_cast<int>( mVertices.count() );
 }
 
 int VertexModel::ringCount() const

src/core/vertexmodel.h

@@ -127,14 +127,14 @@ class QFIELD_CORE_EXPORT VertexModel : public QAbstractListModel
 
     struct VertexChange
     {
-        VertexChange( VertexChangeType type, int &index, const Vertex &vertex )
+        VertexChange( VertexChangeType type, qsizetype &index, const Vertex &vertex )
           : type( type )
           , index( index )
           , vertex( vertex )
         {}
 
         VertexChangeType type = NoChange;
-        int index = -1;
+        qsizetype index = -1;
         Vertex vertex;
     };
 
@@ -253,7 +253,7 @@ class QFIELD_CORE_EXPORT VertexModel : public QAbstractListModel
 
     int currentVertexIndex() const;
 
-    void setCurrentVertexIndex( int currentIndex );
+    void setCurrentVertexIndex( qsizetype currentIndex );
 
     Vertex vertex( int row ) const;
 
@@ -330,11 +330,11 @@ class QFIELD_CORE_EXPORT VertexModel : public QAbstractListModel
      * @param newVertex the new vertex index
      * @param forceUpdate if true, it will force to update all vertices and emit signal
      */
-    void setCurrentVertex( int newVertex, bool forceUpdate = false );
+    void setCurrentVertex( qsizetype newVertex, bool forceUpdate = false );
 
     EditingMode mMode = NoEditing;
     //!
-    int mCurrentIndex = -1;
+    qsizetype mCurrentIndex = -1;
     int mRingCount = 0;
     Qgis::GeometryType mGeometryType = Qgis::GeometryType::Line;
     Qgis::WkbType mGeometryWkbType = Qgis::WkbType::Unknown;
@@ -346,7 +346,7 @@ class QFIELD_CORE_EXPORT VertexModel : public QAbstractListModel
     bool mIsHovering = false;
 
     QList<VertexChange> mHistory;
-    int mHistoryIndex = -1;
+    qsizetype mHistoryIndex = -1;
     bool mHistoryTraversing = false;
 
     friend class VertexModelTest;