Skip to content

Commit 07715df

Browse files
authored
Merge pull request #4 from opengisch/remove-proxy
Remove nginx proxy config, add more info about dev work and release
2 parents 8ca127b + d2276a4 commit 07715df

File tree

3 files changed

+22
-63
lines changed

3 files changed

+22
-63
lines changed

README.md

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,27 @@
22

33
## Local DEV setup
44
Run the docker compose file to fire up a local instance of the webGIS. It mounts the contents of
5-
the app folder and also the configuration files copied from Thalwil TEST env (themes.json, config.json).
5+
the app folder and uses the configuration files (themes.json, config.json) in the `dev` directory. These were copied from Thalwil TEST env.
66

7+
Note that files in the `dev` directory and the `docker-compose.yaml` are only needed for local development work
8+
and do not get added to the final docker image.
79

8-
### Prevent CORS issues
9-
To prevent CORS issues, the following automatic and manual steps are taken.
10+
## Release a new version
11+
Relevant for a production release are the `Dockerfile` and files in the `app` directory.
12+
The following steps are necessary when releasing a new version.
1013

11-
- Search: A proxy service in the docker compose redirects search requests from localhost:8888 to the TEST env
12-
- Map click / feature info: In themes.json, replace `"featureInfoUrl": "https://maps-test.thalwil.ch` with `"featureInfoUrl": "http://localhost:8888` to point at the proxy
13-
- Theme and basemap thumbnails: These still suffer from CORS blocks, no solution yet
14+
Optional prerequisite when doing a major upgrade:
15+
1. Manually upgrade [opengisch qwc_minimal repository](https://github.com/opengisch/qwc2_minimal) to the latest LTS version of [QWC2](https://github.com/qgis/qwc2-demo-app)
16+
2. Update the files in `app` to fit with the newest version
17+
18+
Then, customer specific changes can be applied in this repo:
19+
1. Add or change files in `app`
20+
2. Update the image tag in the `Dockerfile`, e.g.:
21+
3. `from 2024-lts.0` to `2024-lts.1`
22+
4. or when doing a major upgrade: `2025-lts.0`
23+
3. In the [rgdz.thalwil.deployment repo](https://github.com/opengisch/rgdz.thalwil.deployment/tree/master), update the docker image URL to point at the new image version
24+
4. On the production server, pull rgdz.thalwil.deployment repo
25+
5. Restart docker containers
26+
27+
28+
By only updating the URL for dev and/or test environment in step 3, you can test changes without touching production.

dev/nginx_proxy.conf

Lines changed: 0 additions & 51 deletions
This file was deleted.

docker-compose.yaml

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,4 @@ services:
1414
- ./app/js/Help.jsx:/app/js/Help.jsx
1515
- ./app/js/SearchProviders.js:/app/js/SearchProviders.js
1616
- ./app/index.html:/app/index.html
17-
proxy:
18-
image: nginx
19-
ports:
20-
- "8888:8888"
21-
volumes:
22-
- ./dev/nginx_proxy.conf:/etc/nginx/nginx.conf
17+

0 commit comments

Comments
 (0)