Skip to content

Commit 4cd2eb1

Browse files
authored
Ambiguity in _Example adding an attribute to a built-in layer_ (#152)
The current example adds the "source" attribute to the Building layer. Unfortunately, `source()` is also a name of a method used in the code. The method name should not be changed if a different attribute is needed. If a naive developer, who wants to add the "name" attribute, replace all instances of `source` with `name` ```diff @@ -166,6 +166,7 @@ public class Building implements .setAttrWithMinzoom(Fields.RENDER_MIN_HEIGHT, renderMinHeight, 14) .setAttrWithMinzoom(Fields.COLOUR, color, 14) .setAttrWithMinzoom(Fields.HIDE_3D, hide3d, 14) + .setAttrWithMinzoom("name", element.name().getTag("name"), 14) .setSortKey(renderHeight); if (mergeZ13Buildings) { feature ``` a compilation error is produced ``` [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] .../planetiler-openmaptiles/src/main/java/org/openmaptiles/layers/Building.java:[169,44] cannot find symbol symbol: method name() location: variable element of type org.openmaptiles.generated.Tables.OsmBuildingPolygon ``` To clarify the matters, this PR adds the attribute "name" that differs from any method in the additional line.
1 parent 3c759b2 commit 4cd2eb1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

README.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,15 @@ the [layers package](src/main/java/org/openmaptiles/layers), and make a change t
4545
Example adding an attribute to a built-in layer
4646
</summary>
4747

48-
For example to copy over the source attribute from OpenStreetMap elements to the building layer,
48+
For example to copy over the name attribute from OpenStreetMap elements to the building layer,
4949
modify [Building.java](src/main/java/org/openmaptiles/layers/Building.java):
5050

5151
```diff
5252
@@ -166,6 +166,7 @@ public class Building implements
5353
.setAttrWithMinzoom(Fields.RENDER_MIN_HEIGHT, renderMinHeight, 14)
5454
.setAttrWithMinzoom(Fields.COLOUR, color, 14)
5555
.setAttrWithMinzoom(Fields.HIDE_3D, hide3d, 14)
56-
+ .setAttrWithMinzoom("source", element.source().getTag("source"), 14)
56+
+ .setAttrWithMinzoom("name", element.source().getTag("name"), 14)
5757
.setSortKey(renderHeight);
5858
if (mergeZ13Buildings) {
5959
feature

0 commit comments

Comments
 (0)