Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to export source_rate units when writing step in depletion simulation #3281

Open
lewisgross1296 opened this issue Jan 28, 2025 · 0 comments

Comments

@lewisgross1296
Copy link
Contributor

Description

Add units to the source_rate data exported to h5 on depletion step writes. Currently, restart or continue runs (coming soon) just assume the user has the same units in the new simulation as the initial. The simulation will run and not error if you change between power, power_density, or source_rate when providing new data to the Operator (or reading from a Results file).

Alternatives

Burden the user to ensure they use the correct units when restarting/continuing depletion.

Compatibility

Probably don't not need to change the API but would add some checking / verification on the back end when going to/from hdf5.

See #3272. Tagging @pshriwise in case I missed something important

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant